Conversation
erral
marked this pull request as ready for review
May 30, 2026 09:41
Member
|
we dont need that one with #88 now merged and released |
thet
pushed a commit
to thet/mxdev
that referenced
this pull request
Sep 28, 2026
Section ownership used an unanchored str.startswith match, so a hook namespace like "uv" silently classified any section whose name merely started with "uv" (e.g. uvst.addon, uvxs.addon) as a hook section and dropped it from the package list - never checked out, never written to requirements, and with no diagnostic. Anchor the match: a section belongs to a hook only when its name is exactly the namespace or is prefixed with "<namespace>:". A colon cannot occur in a package name, so it unambiguously separates hook sections from package sections and removes the false-positive class permanently. This is an alternative to mxstack#87, which worked around the bug by renaming the uv hook's namespace to "__uv__". Fixing the matching logic instead keeps the clean "uv" namespace and protects every current and future hook, not just this one. Hook config sections previously named [namespace-section] must be renamed to [namespace:section]; EXTENDING.md updated accordingly. The only known hook (uv) owns no mx.ini sections, so the practical impact is nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found out that packages whose name started with
uvlikeuvst.addonoruvxs.addonwhere not properly handled by the hook.We have found out that the sections in
mx.inifile starting with the same name as the hook's namespace (in this caseuv) are reserved for hooks (see).So we need to change the namespace of our hook in order not to have clashes.
@pbauer