runmarker: the RUN marker carries how far behind the tree is — rebuilt clean (supersedes #572) - #590
Merged
Merged
Conversation
…t clean Supersedes #572. Same feature, none of the collateral. Diagnosed by nforma-next-c2: #572's branch changed 54 files, but only THREE are the feature. The other 51 delete 8,846 lines of hardening the commit never meant to touch — 14 suites lose the __pycache__ preamble, doctrine-watch.py loses delta_for() and read_delta_cmd() whole, which is why test_doctrine_watch reported 8 failures on a suite testing functions the same commit deleted. ⛔ It was not a revert. c2 swept ALL 406 first-parent commits of origin/main: the minimum diff to the branch tree is 54 and never drops below it, so the tree matches no point in main's history, past or present. It is a stale worktree committed wholesale — `git add -A` recording ~14 merges of absences as deliberate deletions on top of a fresh parent. Verified here by testing the IMPLICATION rather than repeating the evidence: if the deletions are collateral, the content must still be alive on main. __pycache__ guard, files carrying it origin/main 32 · 41777a5 18 doctrine-watch.py def delta_for origin/main 1 · 41777a5 0 CONTROL, a token absent from both 0 ⇒ Confirmed. So this branch takes only the three feature files onto a fresh base: tools/runmarker.py +37 -1 tools/test_runmarker.py +41 -0 .claude/doctrine-watermark +1 -0 ───────────────────────── +79 -1, 3 files, exactly as c2 predicted ⚠ And a second, independent argument for the rebuild that neither of us had at the time: the preamble those 14 files lose is the `sys.dont_write_bytecode` guard. I was bitten by its absence today in test_close_condition_scan.py — a size-preserving edit left a stale .pyc and the suite reported FAILED against a file that was already correct. #572 would have re-opened that hole in fourteen more places. ⛔ NOT force-pushed over #572. Force-push is reserved and erases the per-branch reflog (#294); the original branch is retained and #572 is closed pointing here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTMf4EvaTEnDKXY47efRZZ
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #572. Same feature, none of the collateral.
The diagnosis is
nforma-next-c2's#572's branch changes 54 files — but only three are the feature. The other 51 delete 8,846 lines of hardening the commit never meant to touch.
⛔ It is not a revert. c2 swept all 406 first-parent commits of
origin/main: the minimum diff to the branch tree is 54 and never drops below it. The tree matches no point in main's history, past or present — it is a stale worktree committed wholesale,git add -Arecording ~14 merges of absences as deliberate deletions on top of a fresh parent.Verified by testing the implication, not repeating the evidence
If the deletions are collateral, the content must still be alive on main:
⇒ Confirmed. And it explains the red gate directly:
test_doctrine_watchreports 8 failures because the suite is testing functions the same commit deleted.⚠ A second argument neither of us had at the time
The preamble those 14 files lose is the
sys.dont_write_bytecodeguard. I was bitten by its absence today intest_close_condition_scan.py: a size-preserving edit left a stale.pyc, and the suite reportedFAILEDagainst a file that was already correct. ⇒ #572 would have re-opened that hole in fourteen more places.This branch
Three files on a fresh base — +79 −1, exactly the shape c2 predicted. Control:
git diff --name-only origin/mainreturns 3; the guard count on this branch is 33, not 18.test_runmarker0 ·check-tools-index0.⛔ Not force-pushed over #572. Force-push is reserved and erases the per-branch reflog (#294). The original branch is retained and #572 will be closed pointing here.
Diagnosis:
nforma-next-c2. Verification, rebuild and filing: session01DTMf4E.🤖 Generated with Claude Code