Skip to content

Implemented tests for encrypted folders - #17697

Open
daniele-verducci wants to merge 21 commits into
masterfrom
improvement/internal-105265-tests
Open

Implemented tests for encrypted folders#17697
daniele-verducci wants to merge 21 commits into
masterfrom
improvement/internal-105265-tests

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests for encrypted (sub)folders.
Related: #17608

⚠️ The encrypted subfolders-related tests are supposed to fail in this one, until #17608 is merged
The folder unencryption test is failing as well, as the feature it's not working in the current master app!

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.72840% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...cloud/android/operations/e2e/E2EDeletionService.kt 30.00% 9 Missing and 5 partials ⚠️
...i/dialog/setupEncryption/EncryptionKeyGenerator.kt 77.19% 9 Missing and 4 partials ⚠️
...g/setupEncryption/SetupEncryptionDialogFragment.kt 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 4818345
Version 17697
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch 2 times, most recently from 04133f4 to ae74111 Compare September 24, 2026 12:46
@daniele-verducci
daniele-verducci marked this pull request as ready for review September 24, 2026 13:11
alperozturk96
alperozturk96 requested changes Sep 24, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/operations/e2e/E2EDeletionService.kt Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt Outdated
@github-actions

github-actions Bot commented Sep 25, 2026

Copy link
Copy Markdown

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch from d1eace8 to e557a0f Compare September 28, 2026 08:27
@alperozturk96 alperozturk96 added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Sep 28, 2026
@alperozturk96

alperozturk96 commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable-35.0.x

@daniele-verducci
daniele-verducci marked this pull request as draft September 28, 2026 14:35
@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch 2 times, most recently from 36d4edb to 57bd0a7 Compare September 28, 2026 15:25
@daniele-verducci
daniele-verducci marked this pull request as ready for review September 28, 2026 15:30
@daniele-verducci

daniele-verducci commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

@alperozturk96 so now only testReadEncryptedSubfolder should fail.
In first post I said testCreateEncryptedSubfolder should fail, but it's wrong: in fact, when creating an encrypted subfolder the app crashes because after successfully creating it, tries to open it . So it's right all the tests are good but testReadEncryptedSubfolder fails.

@daniele-verducci
Refactoring to extract key generation for better testing
1629667 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Working create and read tests for folder and subfolder
4ce3733 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Fix lint + a small refactoring to make generatePrivateKey() more read…
6830cd4 
…able

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Cleanup keys after tests run
6700dc9 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Added metadata folder check in folder opening check
bd81520 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
daniele-verducci and others added 16 commits September 28, 2026 17:33
@daniele-verducci
Fixed empty capability in test
7d5e51d 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Working encrypted folder test
2c7f0ec 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Refactored & small fixes
3708abd 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Fixed copypasted file copyright text for a newly created file
78152e6 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Implemented unencryption test
4ba5344 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Restricted tests to Nextcloud >= 30
b331324 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Fixed lint
89b55d5 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Non-nullable keywords, replaced annotation
3938e46 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Moved generateKeyPair into EncryptionKeyGenerator
607d42f 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Sealed class for generatePrivateKey() result
ccd62d4 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Missing imports
d96f28d 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Spotless apply
13334a0 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
Fix Codacy magic number
37e2e17 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@alperozturk96 @daniele-verducci
fix tests
4317184 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @daniele-verducci
remove upload logic since: will be fixed via https://github.com/nextc…
fa74cf8 
…loud/android/pull/17608/changes#diff-7cffc15456a4f941a07f401277af2164ca9454b434a40e7e811ef48f367aadb8R116

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@daniele-verducci
Restore metadata upload
4818345 
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch from 57bd0a7 to 4818345 Compare September 28, 2026 15:33
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5656
Dodgy code184184
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1717
Total353353

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17697-IT-master-16-00

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17697-IT-stable35-16-05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky
@alperozturk96 alperozturk96 Awaiting requested review from alperozturk96

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud App 35.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@daniele-verducci @alperozturk96