fix: keep the description editor menu above tables - #8426
Open
mael-chouteau wants to merge 1 commit into
Open
mael-chouteau wants to merge 1 commit into
mael-chouteau wants to merge 1 commit into
Conversation
The sidebar override set the Text menubar to z-index 1, so its dropdowns painted under table widgets. Use 4 so the menu stays above those widgets and still below tag menus and the sticky sidebar header. Fixes nextcloud#7789 Signed-off-by: chouteau Ma毛l <chouteaumael@gmail.com>
mael-chouteau
requested review from
grnd-alt and
luka-nextcloud
as code owners
September 23, 2026 15:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The formatting menu in a card description was sliding under tables. Deck forced that menu to
z-index: 1, while the Text editor draws table controls atz-index: 3. Because the menu is sticky, that low value also trapped its dropdowns underneath the table.This raises the sidebar menu to
z-index: 4, the same level the Text app uses for this bar. That is high enough to paint above tables, and still low enough to stay under the tag and user menus (50) and the sticky card header (100). A much higher value would cover those menus again, which is what happened when this override was100.Fixes #7789
TODO
Checklist
No automated test covers this stacking order. The change is one CSS value, chosen to sit between the existing layers.