feat(composer): insert images from Files - #13477
Conversation
|
|
Very cool! I'm a little hesitant about introducing TypeScript parts just out of the blue, and mix different styles in the codebase. Side note not meant to be targetted in this PR: the list of mime types is OK, but different from the one in MessageController, which is different from the one in AvatarService. Sooner or later, we should have a single list of "mimetypes that can be considered an image and put into an img tag"... |
I can't reproduce 🤔
|
| try { | ||
| const nodes = await getFilePickerBuilder(t('mail', 'Choose an image')) | ||
| .setMimeTypeFilter(MIME_TYPES) | ||
| .setMultiSelect(false) |
There was a problem hiding this comment.
Set to false here, which is correct if you're expecting one file
Thanks for checking. It's actually something different. In single mode it's currently not possible to select a different node when one is already selected. I'd overlooked that it's necessary to unselect the last node first. I filed an issue upstream because it looks unintended to me: nextcloud-libraries/nextcloud-dialogs#2567. Similar to moveOrCopyAction.ts in files the picker now disabled the button if no node is selected and also inserts the filename to be added. Screencast showing the old state: Screencast.From.2026-08-13.10-30-54.mp4 |
6272769 to
6324fbf
Compare
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6324fbf to
feb8e15
Compare
|
4 participants
Register an integration in CKEditor's insert image dropdown that opens the Nextcloud file picker.
🤖 AI (if applicable)