Skip to content

🔄 synced file(s) with nextcloud/android-config - #6758

Open
nextcloud-android-bot wants to merge 1 commit into
masterfrom
repo-sync/android-config/master
Open

nextcloud-android-bot wants to merge 1 commit into
masterfrom
repo-sync/android-config/master

Conversation

@nextcloud-android-bot

@nextcloud-android-bot nextcloud-android-bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

synced local file(s) with nextcloud/android-config.

Changed files
  • synced local directory .github/workflows/ with remote directory config/workflows/

This PR was created automatically by the repo-file-sync-action workflow run #36303539357

@nextcloud-android-bot
nextcloud-android-bot force-pushed the repo-sync/android-config/master branch from 871cc29 to 0a60939 Compare September 24, 2026 07:10
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit cf7b59d
Version 6758
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@nextcloud-android-bot
nextcloud-android-bot force-pushed the repo-sync/android-config/master branch 2 times, most recently from 2bf3808 to dd7e6a8 Compare September 26, 2026 07:03
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

📝 Walkthrough

Walkthrough

The analysis and QA workflows now use ubuntu-latest-max and Java 25. The analysis workflow increases Gradle’s maximum heap from 1 GB to 6 GB. The CodeQL init and analyze actions and the Scorecard SARIF upload action now use v4.38.2. The CodeQL workflow also requests Java 25.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to dd7e6

The Gradle JVM may not match the intended Java 25 setting. Confirm the intended JVM before merging; the available evidence does not establish a broken job.

Architecture Summary

Architecture risk: 🔵 Low · up to dd7e6

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/analysis.yml: The analysis job’s runner changed from ubuntu-latest to ubuntu-latest-max.
  • observed — Modified behavior in .github/workflows/analysis.yml: The job now sets up Java 25 instead of Java 21.
  • observed — Modified behavior in .github/workflows/analysis.yml: Gradle’s configured maximum heap increased from 1 GB to 6 GB; the other JVM arguments are unchanged.
  • observed — Modified behavior in .github/workflows/codeql.yml: The CodeQL init and analyze actions are pinned to v4.38.2 instead of v4.38.1, and the Java setup step changes its requested version from 21 to 25. The assemble step is unchanged.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the synchronization and lists the changed directory, but it omits all sections from the repository template, including Screenshots, TODO, Checklist, and AI disclosure. Add the required template sections. Complete the TODO and Checklist items, state whether screenshots and tests are needed, and disclose AI use when applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies an automatic synchronization with nextcloud/android-config. It is concise and related to the main change.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 569c0fad-2452-4d74-ae26-645bb39b393b

📥 Commits

Reviewing files that changed from the base of the PR and between a5ebeb0 and dd7e6a8.

📒 Files selected for processing (4)
  • .github/workflows/analysis.yml
  • .github/workflows/codeql.yml
  • .github/workflows/qa.yml
  • .github/workflows/scorecard.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

with:
distribution: "temurin"
java-version: 21
java-version: 25

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🔎 Supported by static analysis

🏁 Script executed:

set -eu
printf '%s\n' '--- revisions ---'
git rev-parse --verify dd7e6a8db3c793a15773529dd83659d846d1455a
git rev-parse --verify a5ebeb04c457b6b549a42213db873cddd6555c5e
printf '%s\n' '--- changed paths ---'
git diff --name-status a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a
printf '%s\n' '--- analysis workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | nl -ba | sed -n '45,78p'
printf '%s\n' '--- qa workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | nl -ba | sed -n '22,52p'
printf '%s\n' '--- daemon properties ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties | nl -ba
printf '%s\n' '--- relevant diff ---'
git diff --unified=20 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.properties

Repository: nextcloud/talk-android

Length of output: 9704


🏁 Script executed:

set -eu
git rev-parse --verify dd7e6a8db3c793a15773529dd83659d846d1455a
git rev-parse --verify a5ebeb04c457b6b549a42213db873cddd6555c5e
git diff --name-status a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | nl -ba | sed -n '45,78p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | nl -ba | sed -n '22,52p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties | nl -ba
git diff --unified=20 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.properties

Repository: nextcloud/talk-android

Length of output: 9570


🏁 Script executed:

printf '%s\n' '--- changed paths ---'
git diff --name-status a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a
printf '%s\n' '--- analysis workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | nl -ba | sed -n '45,78p'
printf '%s\n' '--- qa workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | nl -ba | sed -n '22,52p'
printf '%s\n' '--- daemon properties ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties | nl -ba
printf '%s\n' '--- relevant diff ---'
git diff --unified=20 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.properties

Repository: nextcloud/talk-android

Length of output: 9604


🏁 Script executed:

git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | sed -n '55,70p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | sed -n '30,45p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties
git diff --unified=5 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.properties

Repository: nextcloud/talk-android

Length of output: 4316


Align the Gradle daemon JVM with Java 25 when these jobs must test Gradle on Java 25.

Both workflows select Java 25, but gradle/gradle-daemon-jvm.properties pins the Gradle daemon to Java 21. Gradle gives daemon JVM criteria precedence over JAVA_HOME, so the daemon remains on Java 21. If Java 25 is intended only for the Gradle client, keep the current criterion.

Suggested fix
-toolchainVersion=21
+toolchainVersion=25
📍 Affects 2 files
  • .github/workflows/analysis.yml#L63-L63 (this comment)
  • .github/workflows/qa.yml#L38-L38

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
@nextcloud-android-bot
nextcloud-android-bot force-pushed the repo-sync/android-config/master branch from dd7e6a8 to cf7b59d Compare September 27, 2026 07:35
@github-actions

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings85138
Errors518

SpotBugs

CategoryBaseNew
Bad practice77
Correctness1111
Dodgy code4545
Internationalization33
Malicious code vulnerability33
Performance88
Security1111
Total8888

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant