🔄 synced file(s) with nextcloud/android-config - #6758
nextcloud-android-bot wants to merge 1 commit into
Conversation
871cc29 to
0a60939
Compare
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
2bf3808 to
dd7e6a8
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 📝 WalkthroughWalkthroughThe analysis and QA workflows now use Priority: ⬇️ Low Merge Risk: 🔵 Low · up to The Gradle JVM may not match the intended Java 25 setting. Confirm the intended JVM before merging; the available evidence does not establish a broken job. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 569c0fad-2452-4d74-ae26-645bb39b393b
📒 Files selected for processing (4)
.github/workflows/analysis.yml.github/workflows/codeql.yml.github/workflows/qa.yml.github/workflows/scorecard.yml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| with: | ||
| distribution: "temurin" | ||
| java-version: 21 | ||
| java-version: 25 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
set -eu
printf '%s\n' '--- revisions ---'
git rev-parse --verify dd7e6a8db3c793a15773529dd83659d846d1455a
git rev-parse --verify a5ebeb04c457b6b549a42213db873cddd6555c5e
printf '%s\n' '--- changed paths ---'
git diff --name-status a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a
printf '%s\n' '--- analysis workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | nl -ba | sed -n '45,78p'
printf '%s\n' '--- qa workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | nl -ba | sed -n '22,52p'
printf '%s\n' '--- daemon properties ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties | nl -ba
printf '%s\n' '--- relevant diff ---'
git diff --unified=20 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.propertiesRepository: nextcloud/talk-android
Length of output: 9704
🏁 Script executed:
set -eu
git rev-parse --verify dd7e6a8db3c793a15773529dd83659d846d1455a
git rev-parse --verify a5ebeb04c457b6b549a42213db873cddd6555c5e
git diff --name-status a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | nl -ba | sed -n '45,78p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | nl -ba | sed -n '22,52p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties | nl -ba
git diff --unified=20 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.propertiesRepository: nextcloud/talk-android
Length of output: 9570
🏁 Script executed:
printf '%s\n' '--- changed paths ---'
git diff --name-status a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a
printf '%s\n' '--- analysis workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | nl -ba | sed -n '45,78p'
printf '%s\n' '--- qa workflow ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | nl -ba | sed -n '22,52p'
printf '%s\n' '--- daemon properties ---'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties | nl -ba
printf '%s\n' '--- relevant diff ---'
git diff --unified=20 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.propertiesRepository: nextcloud/talk-android
Length of output: 9604
🏁 Script executed:
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/analysis.yml | sed -n '55,70p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:.github/workflows/qa.yml | sed -n '30,45p'
git show dd7e6a8db3c793a15773529dd83659d846d1455a:gradle/gradle-daemon-jvm.properties
git diff --unified=5 a5ebeb04c457b6b549a42213db873cddd6555c5e dd7e6a8db3c793a15773529dd83659d846d1455a -- .github/workflows/analysis.yml .github/workflows/qa.yml gradle/gradle-daemon-jvm.propertiesRepository: nextcloud/talk-android
Length of output: 4316
Align the Gradle daemon JVM with Java 25 when these jobs must test Gradle on Java 25.
Both workflows select Java 25, but gradle/gradle-daemon-jvm.properties pins the Gradle daemon to Java 21. Gradle gives daemon JVM criteria precedence over JAVA_HOME, so the daemon remains on Java 21. If Java 25 is intended only for the Gradle client, keep the current criterion.
Suggested fix
-toolchainVersion=21
+toolchainVersion=25📍 Affects 2 files
.github/workflows/analysis.yml#L63-L63(this comment).github/workflows/qa.yml#L38-L38
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
dd7e6a8 to
cf7b59d
Compare
synced local file(s) with nextcloud/android-config.
Changed files
.github/workflows/with remote directoryconfig/workflows/This PR was created automatically by the repo-file-sync-action workflow run #36303539357