Corepack & Gradle 9

[solonovamax]

Hey,

I just wanted to open an issue because I'm currently maintaining my own personal fork of node-gradle in order to add gradle 9 support, as well as support for corepack (#342): https://github.com/solonovamax/gradle-node-plugin/

it's not currently in a condition where I'd feel comfortable PRing it, but it was enough for my usecase.
if you wanted to pull those commits into node-gradle, I'd be more than happy to help with that.
I've based my fork on the update-node-version and update-node-version branches.

Support for corepack was actually relatively straightforward. it seems that you can basically just prefix the command with corepack, and then it Just Works™
e.g. instead of doing pnpm install, you do corepack pnpm install

the one thing that was just rather annoying was fixing the mocking for ExecOperations:
b0a4b48#diff-3e86f30a7042837bd17d78bacc8469493ef25f4b0037fe2a2ddb2e841dd2ab6cL27-R33

[deepy]

That's great news!

I've looked at the changes in the fork and it all looks fine to me, so if you're interested I'd be happy to accept everything up to the corepack changes as-is in a single PR (i.e. up to and including b0a4b48a703637b5e57afc516f0556106de7059c, squashed or not)

Then I can do some additional testing and prepare a release, and we can work on getting the corepack part integrated as well

The fork in general looks fine to me but best of all you've handled all the gnarly parts of the upgrade already 😀

[deepy]

But full disclosure on corepack, I initially lost all interest when it was announced that the bundled version was going to get removed as it's always a little tricky keeping everything working just as well both when download is on and off

[solonovamax]

just realized that I linked this repo and not my repo, oopsies

when it was announced that the bundled version was going to get removed

yeah, this decision still baffles me to this day

Then I can do some additional testing and prepare a release

I do have some amount of unit/integration tests there, though there are definitely some that are missing (at a certain point I kinda got bored of writing the unit/integration tests so I just stopped)
I've tested against against a 9.x version of gradle, however I haven't tested against earlier versions, so this may or may not be 9.x-exclusive (afaik it is)

as for a release, there's definitely quite a few things I'd probably want to clean up, but I could look at doing that over the coming weekend

[deepy]

Right now I'm blocked from making a release due to a combination of failing tests and needing to update the publishing plugin, so your changes gets me 98% of the way there ;-)

I'd be happy to do any cleanup necessary, but I'm also lazy so I'd be happy to let you do it as well 😀

And the cross-version tests are set up with GHA, so testing older versions should be easy enough

[solonovamax]

And the cross-version tests are set up with GHA, so testing older versions should be easy enough

I'm not 100% sure it will even run at all on older versions due to api changes in gradle 9. perhaps this could be worked around if you're willing to do some Funny stuff, but it's a pain in the ass to maintain

[deepy]

That part too is fine, I am willing to do the bare minimum of Some Funny Stuff™ to keep things working and by being back on a modern Gradle version again it should be a smaller pain in the ass than before