fix(react): avoid clipped stability tooltips - #1046
Draft
dabidabi wants to merge 1 commit into
Draft
Conversation
Use the browser-native title tooltip for stability badges so the tooltip is not clipped by the scrolling table of contents. Fixes nodejs#938 Signed-off-by: dabidabi <91039645+dabidabi@users.noreply.github.com> Assisted-by: OpenAI Codex
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AugustinMauroy
left a comment
AugustinMauroy
left a comment
Member
There was a problem hiding this comment.
okay it's worked, but it's a regression that was better before I mean the fix should be applied on the tool-tips component
ovflowd
requested changes
Aug 18, 2026
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
This switches to native browser tooltips whereas the ask is to ensure the current custom tooltips (generated via data-tooltip) don't have the issue. i.e.: this should be as simple as fixing the source CSS behind the tooltips. That might be on @node-core/ui-components or on doc-kit itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titletooltip for stability badges in the meta barWhy
The shared CSS tooltip is rendered inside the meta bar's scrolling table of
contents. When a stability badge wraps near either horizontal edge, that
container clips part of the tooltip. A native tooltip is rendered outside the
scroll container, so its text remains fully visible without adding client-side
JavaScript to the otherwise static table of contents.
Fixes #938.
Validation
prettier --checkon the changed filesAI assistance was used to investigate, implement, test, and review this change.
The commit includes an
Assisted-by: OpenAI Codexattribution.