Skip to content

test: mark SEA tests flaky on linux arm debug#63743

Open
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:test-build-sea
Open

test: mark SEA tests flaky on linux arm debug#63743
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:test-build-sea

Conversation

@trivikr

@trivikr trivikr commented Jun 4, 2026

Copy link
Copy Markdown
Member

The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.

Mark the affected SEA build and application test families as flaky only
on linux arm debug, matching the node-test-commit-arm-debug job
where the flakes have been observed.

Refs:

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 4, 2026
@trivikr trivikr added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 4, 2026
Comment thread test/sea/sea.status
The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.

Mark the affected SEA build and application test families as flaky only
on linux arm debug, matching the node-test-commit-arm-debug job where
the flakes have been observed.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@trivikr trivikr changed the title test: mark SEA tests flaky on linux arm test: mark SEA tests flaky on linux arm debug Jun 5, 2026
@trivikr trivikr requested a review from joyeecheung June 5, 2026 04:36
@trivikr trivikr added review wanted PRs that need reviews. and removed review wanted PRs that need reviews. labels Jun 6, 2026
Comment thread test/sea/sea.status Outdated

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2026
@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2026
@trivikr

This comment was marked as outdated.

@trivikr trivikr requested a review from joyeecheung June 8, 2026 21:11
@trivikr trivikr added review wanted PRs that need reviews. and removed review wanted PRs that need reviews. labels Jun 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63743
βœ”  Done loading data for nodejs/node/pull/63743
----------------------------------- PR info ------------------------------------
Title      test: mark SEA tests flaky on linux arm debug (#63743)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     trivikr:test-build-sea -> nodejs:main
Labels     test, flaky-test, author ready, needs-ci
Commits    2
 - test: mark SEA tests flaky on linux arm debug
 - Update test/sea/sea.status
Committers 2
 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63743
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63743
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-10.md
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Thu, 04 Jun 2026 05:22:05 GMT
   βœ”  Approvals: 3
   βœ”  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/63743#pullrequestreview-4467917972
   βœ”  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63743#pullrequestreview-4452693490
   βœ”  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/63743#pullrequestreview-4464290426
   ✘  GitHub CI failed with status: FAILURE
   β„Ή  Last Full PR CI on 2026-06-10T10:49:11Z: https://ci.nodejs.org/job/node-test-pull-request/74031/
- Querying data for job/node-test-pull-request/74031/
βœ”  Build data downloaded
- Querying failures of job/node-test-commit/88580/
βœ”  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   βœ”  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/27279706663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants