watch: detect files replaced via unlink and create - #63888
Open
marcopiraccini wants to merge 1 commit into
Open
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
ShogunPanda
approved these changes
Jun 13, 2026
|
When can we expect this to be merged? |
trivikr
added
watch-mode
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51621
Refs: #54774
On Linux,
--watchstopped restarting after the first time a watched file was replaced via unlink+create or rename (atomic saves,docker compose watch, bind mounts), so it appeared to "only reload the first time".filterFilewatched each file directly, which binds the inotify watch to the file's inode.On replacement the old inode is unlinked: the watch fires once, then dies; the new file's inode is never watched.
Fix: watch the parent directory non-recursively instead of the file. The directory inode is stable across replacements, and unrelated siblings are still discarded by the filter-mode check in
#onChange. macOS/Windows alreadywatched the directory and were unaffected.