perf_hooks: add missing resource timing attributes - #65017
Conversation
|
Review requested:
|
2ebef57 to
94dca40
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65017 +/- ##
==========================================
- Coverage 90.07% 90.06% -0.02%
==========================================
Files 754 754
Lines 256395 256434 +39
Branches 48494 48507 +13
==========================================
+ Hits 230947 230950 +3
- Misses 16563 16584 +21
- Partials 8885 8900 +15
🚀 New features to boost your workflow:
|
|
Hello @legendecas @jasnell 🖐️ Thank you for all the work that goes into reviewing contributions here! Just a gentle ping in case this PR slipped through the cracks. I would appreciate any feedback whenever you have time, no rush at all. Thanks! |
|
The CI failures persist after a rerun and seem unrelated to the latest changes. Perhaps updating the branch would trigger a fresh CI run. |
Add the finalResponseHeadersStart, firstInterimResponseStart, renderBlockingStatus, contentType and contentEncoding getters to PerformanceResourceTiming and update the WPT status accordingly. Signed-off-by: greenhead <shren0812@gmail.com>
The spec defines responseStart as firstInterimResponseStart when that is not 0, and finalResponseHeadersStart otherwise. Signed-off-by: greenhead <greenheadhq@gmail.com>
Document the five getters PerformanceResourceTiming gained: finalResponseHeadersStart, firstInterimResponseStart, renderBlockingStatus, contentType and contentEncoding, add the missing responseStart entry, and record its new interim-aware behavior. Signed-off-by: greenhead <greenheadhq@gmail.com>
Signed-off-by: greenhead <greenheadhq@gmail.com>
Signed-off-by: greenhead <greenheadhq@gmail.com>
e0e7844 to
86667e4
Compare
Commit Queue failedThis pull request has multiple commits, but no landing policy was selected. Add
commit-queue-squash
The pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
|
Landed in 5b912ed |
Add the
PerformanceResourceTimingattributes from the Resource Timing specification that are still missing in Node.js:finalResponseHeadersStart,firstInterimResponseStart,renderBlockingStatus,contentType, andcontentEncoding.The new getters follow the existing
PerformanceResourceTimingpattern and are included intoJSON(). The WPT status file is updated to enable the tenidlharnesssubtests that now pass.Update
responseStartto returnfirstInterimResponseStartwhen it is non-zero and fall back tofinalResponseHeadersStartotherwise, matching the Resource Timing specification.Tests cover the new getters, default and supplied metadata, the
interim = 0, final > 0fallback, and an entry created by the built-infetch()implementation.Refs: #51589