ffi: refresh cached string buffers on every call - #65051
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
ffi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65051 +/- ##
==========================================
- Coverage 90.33% 90.33% -0.01%
==========================================
Files 760 760
Lines 248522 248517 -5
Branches 46904 46889 -15
==========================================
- Hits 224513 224486 -27
- Misses 15444 15453 +9
- Partials 8565 8578 +13
🚀 New features to boost your workflow:
|
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Native code can mutate temporary string storage during an FFI call. Rewrite cached buffers on every conversion so a later call with the same JavaScript string receives a fresh copy of its UTF-8 bytes. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
ffi-temp-string-buffer-reuse
branch
from
August 9, 2026 23:22
a88fe4c to
8f76513
Compare
jasnell
approved these changes
Aug 10, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65050
Native code can mutate temporary string storage during an FFI call. Rewrite cached buffers on every conversion so a later call with the same JavaScript string receives a fresh copy of its UTF-8 bytes.
Assisted-by: codex:gpt-5.6-sol