src: add v8::Local specialization for MaybeStackBuffer - #65159
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/maybestackbuffer-v8-local
branch
4 times, most recently
from
August 9, 2026 05:29
2b1fac0 to
f819d7c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65159 +/- ##
==========================================
- Coverage 90.33% 90.31% -0.02%
==========================================
Files 751 751
Lines 249835 249879 +44
Branches 47175 47192 +17
==========================================
+ Hits 225681 225683 +2
- Misses 15546 15587 +41
- Partials 8608 8609 +1
🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
jasnell
force-pushed
the
jasnell/maybestackbuffer-v8-local
branch
from
August 9, 2026 15:33
f819d7c to
abf8c83
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/maybestackbuffer-v8-local
branch
from
August 12, 2026 18:46
abf8c83 to
a052553
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
marked this pull request as draft
August 12, 2026 19:43
This comment was marked as resolved.
This comment was marked as resolved.
Long-term itch. Per v8 rules, we're not supposed to be heap allocating v8::Local's; instead we're supposed to be using v8::LocalVector. Create a specialization of MaybeStackBuffer that uses either a stack array of v8::Locals or v8::LocalVector with some additional utility improvements. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
marked this pull request as ready for review
August 14, 2026 02:53
jasnell
force-pushed
the
jasnell/maybestackbuffer-v8-local
branch
from
August 14, 2026 02:53
a052553 to
996535d
Compare
Qard
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-term itch. Per v8 rules, we're not supposed to be heap allocating v8::Local's; instead we're supposed to be using v8::LocalVector. Create a specialization of MaybeStackBuffer that uses either a stack array of v8::Locals or v8::LocalVector with some additional utility improvements.