deps: update V8 to 15.2 by targos · Pull Request #65161 · nodejs/node

targos · 2026-08-09T09:55:02Z

nodejs-github-bot · 2026-08-09T09:55:09Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8

targos · 2026-08-09T20:25:44Z

I guess this is blocked by #64408 (https://github.com/nodejs/node/actions/runs/31307061482/job/93228984418?pr=65161)

joyeecheung · 2026-08-10T15:01:25Z

Uploaded https://chromium-review.googlesource.com/c/v8/v8/+/8223266 to fix the Linux AArch64 build (haven't tested on real Linux AArch64 yet, but that's what the error message suggests)

GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs/node#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230}

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 15.2. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools Refs: nodejs#55784 PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

GCC emits warnings because of the trailing backslashes. PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

In illumos, madvise(3C) now takes `void *` for its first argument post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so builds can work either way. PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

aix: simplify OS::DecommitPages implementation Replace complex mmap/munmap retry logic with mprotect + madvise approach. This fixes a race condition that was causing test failures in Node.js. Node.js stress test was run with this fix and testing shows 0 failures out of 1000 runs of wpt/test-wasm-jsapi with this patch compared to 224 failures without it. Refs: nodejs#62647 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7780464 PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [simd] Disable SVE implementation of array search for GCC GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230} Refs: v8/v8@68cf9ec

Co-Authored-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-Off-By: Michaël Zasso <targos@protonmail.com>

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

Post-mortem libraries should use v8's debug_helper library instead.

- Set/GetPrototype - Holder Signed-Off-By: Michaël Zasso <targos@protonmail.com>

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

ICU_UTIL_DATA_SHARED had been removed since https://crrev.com/c/1513615, but Node.js still defined it and relied on the removed path on Windows, so the ICU initialization in mksnapshot had been silently failing since then. https://crrev.com/c/7679153 made the failure visible so the build started breaking on Windows. Fix it by always using ICU_UTIL_DATA_STATIC since we already compile the ICU data statically in. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

V8 bumped its wire-format version from 0x0f to 0x10. Update the expected hex in test-v8-serdes, and derive the v8 header bytes dynamically in test-runner-v8-deserializer so it tracks future bumps automatically. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

V8 no longer supports JSON.parse on worker isolates while the shared string table is enabled. Since --harmony-struct enables that table and Node workers parse process.config during bootstrap, use direct MessageChannel instead of a worker. Signed-Off-By: Michaël Zasso <targos@protonmail.com>

richardlau · 2026-08-13T12:28:07Z

FWIW https://chromium-review.googlesource.com/c/v8/v8/+/8236132 was opened by @sravani1510 to address the AIX build failure that is occurring on our V8 nightly builds.

targos · 2026-08-13T12:54:50Z

@nodejs/platform-windows We're hitting a weird error on Windows:

https://github.com/nodejs/node/actions/runs/31699320590/job/94444346312?pr=65161

  Unexpected command-line argument "src/debug/debug-wasm-obects.q", expected a .tq file.
C:\Program Files\Microsoft Visual Studio\18\Enterprise\MSBuild\Microsoft\VC\v180\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for '..\..\out\Release\\torque.exe' exited with code 3. [D:\a\node\node\tools\v8_gypfiles\run_torque.vcxproj]

This wrong path doesn't exist in the code.

targos · 2026-08-13T15:25:23Z

@legendecas Can you help with the perfetto build?

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

legendecas · 2026-08-14T12:49:30Z

Fixed the perfetto build. But I think the CI is failing for tests in large pages. Likely not related.

targos · 2026-08-14T13:13:18Z

Thanks. Summary of the remaining issues in GitHub CI:

I'll start a Jenkins CI for more coverage.

nodejs-github-bot · 2026-08-14T13:21:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75841/

nodejs-github-bot · 2026-08-14T13:21:37Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7311/

nodejs-github-bot · 2026-08-14T13:22:07Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7311/

nodejs-github-bot · 2026-08-14T13:22:08Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7311/

richardlau · 2026-08-14T16:22:00Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7311/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7311/

Been talking to @miladfarca about this:

16:01:57 === mjsunit/maglev/regress-498816446-3 ===
16:01:57 --- stderr ---
16:01:57 V8 is running with experimental features enabled. Stability and security will suffer.
16:01:57 --- stdout ---
16:01:57 test/mjsunit/maglev/regress-498816446-3.js:25: RangeError: Array buffer allocation failed
16:01:57 ta = new Int32Array(0xffffffff+1);
16:01:57      ^
16:01:57 RangeError: Array buffer allocation failed
16:01:57     at new ArrayBuffer (<anonymous>)
16:01:57     at new Int32Array (<anonymous>)
16:01:57     at test/mjsunit/maglev/regress-498816446-3.js:25:6
16:01:57 Command: out.gn/s390x.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/maglev/regress-498816446-3.js --random-seed=-770474680 --nohard-abort --allow-natives-syntax --maglev-object-tracking --maglev
16:01:57 
16:01:57 ===
16:01:57 === 1 tests failed
16:01:57 ===
16:01:57 >>> 17287 base tests produced 15072 (87%) non-filtered tests
16:01:57 >>> 15072 tests ran

The Linux ppc64le and s390x machines being tested on have 8GB RAM and this test is allocating 16GB.

miladfarca · 2026-08-14T16:52:58Z

Patched it here: https://crrev.com/c/8252113

targos changed the title ~~deps: update V8 to 15.2.124.7~~ deps: update V8 to 15.2 Aug 9, 2026

nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 9, 2026

targos mentioned this pull request Aug 9, 2026

deps: update V8 to 14.9 #64784

Open

targos and others added 21 commits August 13, 2026 14:13

deps: update V8 to 15.2.124.9

f229070

deps: update Rust crates for V8 15.2.124.9

919bb0b

build: reset embedder string to "-node.0"

70d2f50

src: update NODE_MODULE_VERSION to 150

b65a010

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 15.2. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: patch V8 to avoid duplicated zlib symbol

5ad8871

PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

deps: patch V8 to fix Windows build

742eed5

PR-URL: nodejs#61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

deps: fixup macros.h for GCC support

4fd114f

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

tools: update V8 gypfiles for 14.8

ddc5a13

Co-Authored-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-Off-By: Michaël Zasso <targos@protonmail.com>

tools: update V8 gypfiles for 14.9

16a633e

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

tools: update V8 gypfiles for 15.0

4a79372

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

tools: update V8 gypfiles for 15.1

f230ce7

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

build: disable v8_postmortem_support

5a52c05

Post-mortem libraries should use v8's debug_helper library instead.

src: migrate from deprecated xxxV2 APIs

05c8cac

- Set/GetPrototype - Holder Signed-Off-By: Michaël Zasso <targos@protonmail.com>

src: migrate from v8::PropertyCallbackInfo<void>

a091ac4

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

test: update wpt Wasm jsapi expectations

130c5d8

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

joyeecheung and others added 5 commits August 13, 2026 14:15

test: update test-heapdump-vm-script.js for new version of V8

f5af774

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

src: fix external reference registration for new CFunction lifetime

3056163

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

targos force-pushed the v8-152 branch from 67173bd to 52dcedd Compare August 13, 2026 12:15

build: fix cppgc_base perfetto source scraper

6bb8632

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

Uh oh!

Uh oh!

Conversation

targos commented Aug 9, 2026

Uh oh!

nodejs-github-bot commented Aug 9, 2026 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Aug 9, 2026

Uh oh!

joyeecheung commented Aug 10, 2026

Uh oh!

richardlau commented Aug 13, 2026

Uh oh!

targos commented Aug 13, 2026

Uh oh!

targos commented Aug 13, 2026

Uh oh!

legendecas commented Aug 14, 2026

Uh oh!

targos commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

richardlau commented Aug 14, 2026

Uh oh!

miladfarca commented Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Aug 9, 2026 •

edited by targos

Loading