crypto: fix missing error checks on ASN1_STRING_to_UTF8() - #65200
Open
ndossche wants to merge 1 commit into
Open
crypto: fix missing error checks on ASN1_STRING_to_UTF8()#65200ndossche wants to merge 1 commit into
ndossche wants to merge 1 commit into
Conversation
This function returns a negative error code on error. When it does so, the `value_str` pointer will remain uninitialized and cause a crash later on when it is freed by OPENSSL_free(). Even if it wouldn't crash there, it still fails to signal the error and an empty string may be propagated to the callers. The check also mirrors the other one in the same file. Signed-off-by: ndossche <nora.dossche@ugent.be>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
anonrig
approved these changes
Aug 10, 2026
panva
added
author ready
panva
approved these changes
Aug 10, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daeyeon
approved these changes
Aug 11, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function returns a negative error code on error. When it does so, the
value_strpointer will remain uninitialized and cause a crash later on when it is freed by OPENSSL_free(). Even if it wouldn't crash there, it still fails to signal the error and an empty string may be propagated to the callers. The check also mirrors the other one in the same file.Note: this was found by a static-dynamic analyser I'm developing.
Supersedes nodejs/ncrypto#41