doc: document secure use of new tls.TLSSocket() - #65208
Open
zeexzeex wants to merge 1 commit into
Open
Conversation
Explain that constructing TLSSocket directly does not authenticate the peer. Document ssl.verifyError() and show how to validate certificates and identity on the 'secure' event. Fixes: nodejs#43994 Signed-off-by: Avocado <ujubongbong@gmail.com>
nodejs-github-bot
added
doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43994
Document that constructing a
tls.TLSSocketdirectly does not authenticatethe peer the way
tls.connect()does.Changes in
doc/api/tls.md:certificate and identity
'secureConnect',authorized, andauthorizationErrorarenot set for direct construction
tlsSocket.ssl.verifyError()and show how to check the certificatechain and host identity on the
'secure'eventThis matches the checks performed in the
tls.connect()path and the patternalready used in
test/parallel/test-tls-socket-default-options.js.