sea: exit cleanly when fuse set without NODE_SEA_BLOB - #65211
Open
sankalpsthakur wants to merge 1 commit into
Open
sea: exit cleanly when fuse set without NODE_SEA_BLOB#65211sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
When the postject fuse byte is set but NODE_SEA_BLOB cannot be found, FindSingleExecutableBlob previously constructed a null string_view and BlobDeserializer NULL-dereferenced. Exit with a clear error instead. Fixes: nodejs#63466 Signed-off-by: Sankalp Thakur <sankalphimself@gmail.com>
sankalpsthakur
force-pushed
the
fix/63466-sea-missing-blob
branch
from
August 11, 2026 10:55
8fcfaaa to
5334e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the SEA fuse byte is set but
postject_find_resource("NODE_SEA_BLOB")returns null (or an empty size),FindSingleExecutableBlobpreviously passed a null pointer intoBlobDeserializer, which SIGSEGVed inReadArithmeticviamemcpy.This adds a null/empty-size guard that prints a clear diagnostic and exits with
ExitCode::kGenericUserErrorinstead.This failure mode shows up when postject flips the fuse but fails to inject a resource (for example host binaries missing a
PT_NOTEprogram header). See also nodejs/postject#107 and nodejs/unofficial-builds#200.Validation
v26.1.0darwin-arm64 binary (fuse sentinel present; mutating fuse alone triggers the broken path).single_executable_application=false), so a full rebuilt binary was not available here; CI will compile and runtest/sea/test-single-executable-application-missing-blob.js.process.execPath, flips the fuse to1without injecting a blob, and asserts exit status1with the new error message (no crash signal).Fixes #63466
AI/LLM disclosure
Made with Cursor