sqlite: reuse cached column names in all() and get() - #65276
Open
geeksilva97 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
geeksilva97
force-pushed
the
post/column-name-cache
branch
from
August 14, 2026 03:48
c7fbb27 to
2822d7d
Compare
araujogui
reviewed
Aug 14, 2026
| Local<Name> key; | ||
| if (!ColumnNameToName(env, stmt, i).ToLocal(&key)) { | ||
| if (owner != nullptr) { | ||
| // Reuses the statement's internalized column names instead of |
Member
There was a problem hiding this comment.
maybe we can cache column names only if persistent is true to avoid caching short-lived statements.
Contributor
Author
There was a problem hiding this comment.
that's an interesting idea. However, IMO, such a change fits caching itself which would be separate change, while this PR is about leveraging cache implementation in paths they are not used yet.
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>
geeksilva97
force-pushed
the
post/column-name-cache
branch
from
August 14, 2026 13:37
2822d7d to
c83e627
Compare
geeksilva97
marked this pull request as ready for review
August 14, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes StatementSync.prototype.all and StatementSync.prototype.get to leverage existing cache