Skip to content

tools: fix the list of globals in ESLint config files - #65281

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:fix-globals
Open

tools: fix the list of globals in ESLint config files#65281
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:fix-globals

Conversation

@aduh95

@aduh95 aduh95 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

As reported in #64894 (comment), we were missing some entries. I also took the liberty of reordering the list in ASCII order as there were only a few items out of order.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Aug 14, 2026
Comment thread lib/eslint.config_partial.mjs Outdated
Comment thread lib/eslint.config_partial.mjs Outdated
Comment thread lib/eslint.config_partial.mjs Outdated
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants