Skip to content

quic: apply multiple fixes to flow control signaling - #65309

Open
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:jasnell/quic-flow-control-fixes
Open

quic: apply multiple fixes to flow control signaling#65309
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:jasnell/quic-flow-control-fixes

Conversation

@jasnell

@jasnell jasnell commented Aug 15, 2026

Copy link
Copy Markdown
Member

Fixing up the QUIC flow control signaling and closed stream handling, expand tests.

Update the flow control handling after the iter streams byte-budget based flow control updates.

@nodejs/quic @pimterry @martenrichter

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 15, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.66667% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.09%. Comparing base (2929417) to head (b5be01b).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/dataqueue/queue.cc 0.00% 15 Missing and 1 partial ⚠️
lib/internal/blob.js 72.41% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65309      +/-   ##
==========================================
- Coverage   90.34%   90.09%   -0.26%     
==========================================
  Files         751      752       +1     
  Lines      250330   251607    +1277     
  Branches    47321    47277      -44     
==========================================
+ Hits       226171   226695     +524     
- Misses      15557    16249     +692     
- Partials     8602     8663      +61     
Files with missing lines Coverage Δ
lib/internal/blob.js 87.43% <72.41%> (-2.44%) ⬇️
src/dataqueue/queue.cc 65.79% <0.00%> (-1.77%) ⬇️

... and 80 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Comment thread src/dataqueue/queue.cc
Comment thread src/dataqueue/queue.cc
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.h Outdated
Comment thread test/parallel/test-quic-flow-control-bidi-simultaneous-volume.mjs
Comment thread test/parallel/test-quic-flow-control-concurrent-volume.mjs
@martenrichter

martenrichter commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Great addition to find more stalls in the pipeline.
Beside the comments, the rest looks good.

@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants