Skip to content

test: simplify timers interval rejection assertion - #65322

Open
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:simplify-test-timers-interval-promisified
Open

test: simplify timers interval rejection assertion#65322
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:simplify-test-timers-interval-promisified

Conversation

@HoonDongKang

Copy link
Copy Markdown
Contributor

Replace a rejection-only try/catch block in
test-timers-interval-promisified.js with assert.rejects().

This simplifies the abort rejection test by verifying both the rejection and
the expected error shape in a single assertion, improving readability without
changing the tested behavior.

Refs:

Tests:

  • ./node test/parallel/test-timers-interval-promisified.js
  • tools/test.py test/parallel/test-timers-interval-promisified.js

Signed-off-by: HoonDongKang <d159123@naver.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (ad7a5b8) to head (4510c52).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65322      +/-   ##
==========================================
+ Coverage   90.11%   90.12%   +0.01%     
==========================================
  Files         752      752              
  Lines      251569   251569              
  Branches    47268    47264       -4     
==========================================
+ Hits       226701   226728      +27     
+ Misses      16233    16183      -50     
- Partials     8635     8658      +23     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants