Skip to content

[v22.x] deps: V8: cherry-pick a6eaf7574109 #65402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanarbol wants to merge 1 commit into
base: v22.x-staging
Choose a base branch
from
+24 −24
Open

[v22.x] deps: V8: cherry-pick a6eaf7574109 #65402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.58',
'v8_embedder_string': '-node.59',

##### V8 defaults for Node.js #####

Expand Down
46 changes: 23 additions & 23 deletions deps/v8/src/logging/code-events.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class Logger {
Logger& operator=(const Logger&) = delete;

bool AddListener(LogEventListener* listener) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
auto position = std::find(listeners_.begin(), listeners_.end(), listener);
if (position != listeners_.end()) return false;
// Add the listener to the end and update the element
Expand All @@ -134,23 +134,23 @@ class Logger {
}

bool RemoveListener(LogEventListener* listener) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
auto position = std::find(listeners_.begin(), listeners_.end(), listener);
if (position == listeners_.end()) return false;
listeners_.erase(position);
return true;
}

bool is_listening_to_code_events() {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
if (listener->is_listening_to_code_events()) return true;
}
return false;
}

bool allows_code_compaction() {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
if (!listener->allows_code_compaction()) return false;
}
Expand All @@ -159,23 +159,23 @@ class Logger {

void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
const char* comment) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeCreateEvent(tag, code, comment);
}
}

void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
Handle<Name> name) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeCreateEvent(tag, code, name);
}
}

void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
Handle<SharedFunctionInfo> shared, Handle<Name> name) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeCreateEvent(tag, code, shared, name);
}
Expand All @@ -184,7 +184,7 @@ class Logger {
void CodeCreateEvent(CodeTag tag, Handle<AbstractCode> code,
Handle<SharedFunctionInfo> shared, Handle<Name> source,
int line, int column) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeCreateEvent(tag, code, shared, source, line, column);
}
Expand All @@ -194,7 +194,7 @@ class Logger {
void CodeCreateEvent(CodeTag tag, const wasm::WasmCode* code,
wasm::WasmName name, const char* source_url,
int code_offset, int script_id) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeCreateEvent(tag, code, name, source_url, code_offset,
script_id);
Expand All @@ -203,80 +203,80 @@ class Logger {
#endif // V8_ENABLE_WEBASSEMBLY

void CallbackEvent(Handle<Name> name, Address entry_point) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CallbackEvent(name, entry_point);
}
}

void GetterCallbackEvent(Handle<Name> name, Address entry_point) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->GetterCallbackEvent(name, entry_point);
}
}

void SetterCallbackEvent(Handle<Name> name, Address entry_point) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->SetterCallbackEvent(name, entry_point);
}
}

void RegExpCodeCreateEvent(Handle<AbstractCode> code, Handle<String> source) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->RegExpCodeCreateEvent(code, source);
}
}

void CodeMoveEvent(Tagged<InstructionStream> from,
Tagged<InstructionStream> to) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeMoveEvent(from, to);
}
}

void BytecodeMoveEvent(Tagged<BytecodeArray> from, Tagged<BytecodeArray> to) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->BytecodeMoveEvent(from, to);
}
}

void SharedFunctionInfoMoveEvent(Address from, Address to) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->SharedFunctionInfoMoveEvent(from, to);
}
}

void NativeContextMoveEvent(Address from, Address to) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->NativeContextMoveEvent(from, to);
}
}

void CodeMovingGCEvent() {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeMovingGCEvent();
}
}

void CodeDisableOptEvent(Handle<AbstractCode> code,
Handle<SharedFunctionInfo> shared) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeDisableOptEvent(code, shared);
}
}

void CodeDeoptEvent(Handle<Code> code, DeoptimizeKind kind, Address pc,
int fp_to_sp_delta) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeDeoptEvent(code, kind, pc, fp_to_sp_delta);
}
Expand All @@ -285,22 +285,22 @@ class Logger {
void CodeDependencyChangeEvent(Handle<Code> code,
Handle<SharedFunctionInfo> sfi,
const char* reason) {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->CodeDependencyChangeEvent(code, sfi, reason);
}
}

void WeakCodeClearEvent() {
base::MutexGuard guard(&mutex_);
base::RecursiveMutexGuard guard(&mutex_);
for (auto listener : listeners_) {
listener->WeakCodeClearEvent();
}
}

private:
std::vector<LogEventListener*> listeners_;
base::Mutex mutex_;
base::RecursiveMutex mutex_;
};

} // namespace internal
Expand Down
Loading