Skip to content

chore(ui): allow ChangeHistory to accept ReactNode - #9115

Merged
bmuenzenmeyer merged 2 commits into
mainfrom
changehistory-reactnode
Aug 21, 2026
Merged

chore(ui): allow ChangeHistory to accept ReactNode#9115
bmuenzenmeyer merged 2 commits into
mainfrom
changehistory-reactnode

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Blocking nodejs/doc-kit#1049

Allows ChangeHistory to accept non-string labels, so that in doc-kit, we can parse these to HTML

Copilot AI lite review requested due to automatic review settings August 21, 2026 16:35
@avivkeller
avivkeller requested a review from a team as a code owner August 21, 2026 16:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Aug 21, 2026 4:36pm

Request Review

Signed-off-by: Aviv Keller <me@aviv.sh>
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.05%. Comparing base (147063e) to head (e7df80f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9115   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          86       86           
  Lines        6046     6046           
  Branches      358      358           
=======================================
  Hits         5203     5203           
  Misses        839      839           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.06 MB
New Total First Load JS 7.06 MB
Delta 0 B (0.00%)

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to fast-track

@bmuenzenmeyer
bmuenzenmeyer added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit e5ec412 Aug 21, 2026
21 checks passed
@bmuenzenmeyer
bmuenzenmeyer deleted the changehistory-reactnode branch August 21, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants