TST: add edge case tests for npv and irr (gh-58) - #155
Open
Eshan-kumar-jain wants to merge 1 commit into
Open
Eshan-kumar-jain wants to merge 1 commit into
Eshan-kumar-jain wants to merge 1 commit into
Conversation
Author
|
@Kai-Striega could you approve the CI workflows when you have a moment? Happy to make any changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #58 by adding edge case tests for
npvandirr.New tests:
npv: zero rate, all-negative cashflows, single cashflowirr: single positive cashflow, zero cashflows in the middle(expected value derived analytically rather than hard-coded)
Leaves #58 open, since it covers the other functions too.
While testing I noticed two behaviours that look unintended, so I
did not write tests locking them in:
npf.irr([])raises a bareIndexError(fromrow[0]on an empty row)npf.irr([-100, np.nan, 110])raisesLinAlgErrorfromnp.roots,whereas
npvreturns NaN for NaN inputHappy to add tests for these once the intended behaviour is decided.