Commit eca44d3
committed
test(service-automation): hold the caller's bound and refuse the combinators this double does not implement
Two further gates were RED on this same in-process engine double before this
branch's last head, and neither had run in CI: the lint job executes its gates
sequentially under `bash -e`, so check:engine-double-contract's exit 1 halted
the job and masked every step behind it. Both are the same defect class as the
finding that halted it — a test double looser than the engine it stands in for
— in the same literal, and both gates state their baseline never grows, so the
mechanical fix each prints is the only route.
check:where-matcher — `matches` read a combinator as a FIELD NAME. No row
carries a column called `$or`, so such a clause silently drops every row and
this arm would report "nobody was reached" for a reason that is not the one
under test, in the very file written to make that distinction visible. The
store answers scalar equality, so it now refuses a combinator loudly rather
than answering wrongly.
check:objectql-double-limit — `find` applied the caller's bound by truthiness,
so `limit: 0` returned every row: the one call that asked for none. Applied by
presence now, after the filter.
Neither baseline gained a file ("no files added", both gates). No assertion and
no case was touched: the diff contains zero `expect(`/`it(`/`describe(` lines,
and all nine cases of the differential control still pass on both arms,
CONTROLs included — the in-process arm still genuinely delivers.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012zTkyNHJ7TkuN2oXtP5x371 parent 47b19ae commit eca44d3
1 file changed
Lines changed: 22 additions & 3 deletions
File tree
- packages/services/service-automation/src/builtin
Lines changed: 22 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
234 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
235 | 251 | | |
236 | 252 | | |
237 | 253 | | |
| |||
241 | 257 | | |
242 | 258 | | |
243 | 259 | | |
244 | | - | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
245 | 264 | | |
246 | 265 | | |
247 | 266 | | |
| |||
0 commit comments