You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[finding · UNVERIFIED, derived from reading] On a stranded resubmit strand the row stays returned, so a second submitter resubmit appears to pass every approvals door guard and insert a second action: 'resubmit' row against the "at most one such action row" assumption #17601
⚠️This card records a hypothesis DERIVED FROM READING and explicitly NOT EXECUTED. That belongs in the first line, not a footnote: the at-tier reviewer that raised it said so plainly, and an unexecuted derivation is something to verify, ⛔ not a finding to assert. The first thing this card owes is a reproduction attempt — which may falsify it.
Filed unassigned by the domain:spec execution seat, out of the final at-tier re-read of PR #17567 (card #15389). No severity asserted; routing and grading are triage's.type prefilled Bug on the reading below; ⛔ correct it if the reproduction comes back negative.
The shape
continueRestoredRun repairs three strand shapes. The two the PR's prose addresses leave the row where no front door can issue the continuation it owes. The third — a stranded resubmit, paused at the approval_revise node (packages/plugins/plugin-approvals/src/approval-service.ts:5095-5099, rebuilt at :4867-4901) — leaves the row returnedwith no newer row.
⇒ On that strand, a second resubmit by the submitter appears to pass every door guard the reviewer read:
:3870 status !== 'returned' → passes: the row IS 'returned'
:3874 non-submitter → passes: the same submitter calls
assertLatestForRun → passes: no newer row exists
the collision check → passes
assertRunResumable → passes via hasSuspendedRun
:3918 resumes APPROVAL_BRANCH_LABELS.resubmit ← the owed edge
⇒ And a second call would insert a second action: 'resubmit' row, against the "at most one such action row" discriminator assumption recorded at :4877-4880.
Why it matters if it reproduces
That discriminator is how resolveRecordedContinuation decides which continuation a stranded run owes. Two rows where the code assumes at most one is a reconstruction problem, ⛔ not a cosmetic one: the repair verb could then read the wrong edge on a later strand of the same run.
What must happen first, and ⛔ in this order
Reproduce it, or falsify it. Drive a real stranded resubmit to the approval_revise pause, call resubmit a second time as the submitter, and read what actually happens — the guard outcome and whether a second action: 'resubmit' row lands. ⛔ Do not fix anything before this. ⚠️ A guard the reviewer did not read may refuse it, in which case this card closes as not-planned with the reading attached, which is a good outcome.
Only if it reproduces, the fix has two candidate shapes and the choice is not this card's to make: close the path at the door, or scope the "nobody could" prose explicitly to the approval-node pause so the sentence stops over-claiming. ⚠️ The first narrows a published accept set and would be Clause-②: yes with its own contract review; the second is prose. ⇒ Which one is right is a ruling-grade question about whether a second resubmit on that strand is legitimate, and it should go to the decision box rather than be chosen by the implementing round.
⛔ What this card does NOT claim
⛔ Not that PR feat(spec): declare continueRestoredRun on the IApprovalService contract #17567 caused it. Pre-existing, unchanged code. The PR's published sentence is scoped to the approval node / suspension and is true within that scope — the reviewer verified it line by line. The hazard is a reader generalising "nobody could" past that scope.
⛔ Not that the second call succeeds. Every step above is read from source; none was executed.
⛔ No claim about the other two strand shapes, which the reviewer confirmed are correctly described.
⛔ No sweep for sibling "at most one" assumptions elsewhere in the file was run; asserting the rest are safe would be a zero nobody measured.
Filed unassigned by the
domain:specexecution seat, out of the final at-tier re-read of PR #17567 (card #15389). No severity asserted; routing and grading are triage's.typeprefilledBugon the reading below; ⛔ correct it if the reproduction comes back negative.The shape
continueRestoredRunrepairs three strand shapes. The two the PR's prose addresses leave the row where no front door can issue the continuation it owes. The third — a strandedresubmit, paused at theapproval_revisenode (packages/plugins/plugin-approvals/src/approval-service.ts:5095-5099, rebuilt at:4867-4901) — leaves the rowreturnedwith no newer row.⇒ On that strand, a second
resubmitby the submitter appears to pass every door guard the reviewer read:⇒ And a second call would insert a second
action: 'resubmit'row, against the "at most one such action row" discriminator assumption recorded at:4877-4880.Why it matters if it reproduces
That discriminator is how
resolveRecordedContinuationdecides which continuation a stranded run owes. Two rows where the code assumes at most one is a reconstruction problem, ⛔ not a cosmetic one: the repair verb could then read the wrong edge on a later strand of the same run.What must happen first, and ⛔ in this order
resubmitto theapproval_revisepause, callresubmita second time as the submitter, and read what actually happens — the guard outcome and whether a secondaction: 'resubmit'row lands. ⛔ Do not fix anything before this.Clause-②: yeswith its own contract review; the second is prose. ⇒ Which one is right is a ruling-grade question about whether a secondresubmiton that strand is legitimate, and it should go to the decision box rather than be chosen by the implementing round.⛔ What this card does NOT claim
continueRestoredRunon theIApprovalServicecontract #17567 caused it. Pre-existing, unchanged code. The PR's published sentence is scoped to theapprovalnode / suspension and is true within that scope — the reviewer verified it line by line. The hazard is a reader generalising "nobody could" past that scope.domain:speclabel set,state=all, since 2026-07-01 ⇒ 400 issues ([security] datasource credential in a nested config position is served in cleartext on read — redaction is top-level-key-only #13405–The ADR-0087 ledger entry for the aggregate x field-type refusal says "no non-temporal pair changes behaviour" — PR #17559 makes that false, andobjectstack migrate meta/ the upgrade guide are its only readers #17561) grepped forat most one such action,revise window,second resubmit,sys_approval_action— zero hits. Lit controls on the same corpus:restoreConsumedSuspension→ 3 cards (approvals:restoreConsumedSuspensionre-arms the pause but the approvals door cannot continue it — a restored approval suspension can only be cancelled, never decided #15389, [spec] DeclarecancelRunandrestoreConsumedSuspensiononIAutomationService— #13953's ruled contract half, step (1), never filed #16495, automation resume door: the delegation exit answersrepairable: falsefor a runrestoreConsumedSuspensionnow re-arms — and the schema's own describe states the opposite reason #17541),resubmit→ 1 ⇒ the zeros are readings.since=2026-07-01and by the corpus ceiling The ADR-0087 ledger entry for the aggregate x field-type refusal says "no non-temporal pair changes behaviour" — PR #17559 makes that false, andobjectstack migrate meta/ the upgrade guide are its only readers #17561.domain:*.packages/plugins/plugin-approvals, so this may be adomain:servicescard rather thandomain:spec. ⛔ Not this seat's call.Refs: #15389 / PR #17567 (where it was found) · #15966 (the class member) · #16495 · #13953.
domain:specexecution seat ·session_01MkQhmuuJAVDjmeWNixwDDH· filed 2026-09-11T02:10ZGenerated by Claude Code