Skip to content

[finding · UNVERIFIED, derived from reading] On a stranded resubmit strand the row stays returned, so a second submitter resubmit appears to pass every approvals door guard and insert a second action: 'resubmit' row against the "at most one such action row" assumption #17601

Description

@os-bill

⚠️ This card records a hypothesis DERIVED FROM READING and explicitly NOT EXECUTED. That belongs in the first line, not a footnote: the at-tier reviewer that raised it said so plainly, and an unexecuted derivation is something to verify, ⛔ not a finding to assert. The first thing this card owes is a reproduction attempt — which may falsify it.

Filed unassigned by the domain:spec execution seat, out of the final at-tier re-read of PR #17567 (card #15389). No severity asserted; routing and grading are triage's. type prefilled Bug on the reading below; ⛔ correct it if the reproduction comes back negative.

The shape

continueRestoredRun repairs three strand shapes. The two the PR's prose addresses leave the row where no front door can issue the continuation it owes. The third — a stranded resubmit, paused at the approval_revise node (packages/plugins/plugin-approvals/src/approval-service.ts:5095-5099, rebuilt at :4867-4901) — leaves the row returned with no newer row.

⇒ On that strand, a second resubmit by the submitter appears to pass every door guard the reviewer read:

:3870   status !== 'returned'        → passes: the row IS 'returned'
:3874   non-submitter                → passes: the same submitter calls
        assertLatestForRun           → passes: no newer row exists
        the collision check          → passes
        assertRunResumable           → passes via hasSuspendedRun
:3918   resumes APPROVAL_BRANCH_LABELS.resubmit   ← the owed edge

⇒ And a second call would insert a second action: 'resubmit' row, against the "at most one such action row" discriminator assumption recorded at :4877-4880.

Why it matters if it reproduces

That discriminator is how resolveRecordedContinuation decides which continuation a stranded run owes. Two rows where the code assumes at most one is a reconstruction problem, ⛔ not a cosmetic one: the repair verb could then read the wrong edge on a later strand of the same run.

What must happen first, and ⛔ in this order

  1. Reproduce it, or falsify it. Drive a real stranded resubmit to the approval_revise pause, call resubmit a second time as the submitter, and read what actually happens — the guard outcome and whether a second action: 'resubmit' row lands. ⛔ Do not fix anything before this. ⚠️ A guard the reviewer did not read may refuse it, in which case this card closes as not-planned with the reading attached, which is a good outcome.
  2. Only if it reproduces, the fix has two candidate shapes and the choice is not this card's to make: close the path at the door, or scope the "nobody could" prose explicitly to the approval-node pause so the sentence stops over-claiming. ⚠️ The first narrows a published accept set and would be Clause-②: yes with its own contract review; the second is prose. ⇒ Which one is right is a ruling-grade question about whether a second resubmit on that strand is legitimate, and it should go to the decision box rather than be chosen by the implementing round.

⛔ What this card does NOT claim

⚠️ Routing note: the code is packages/plugins/plugin-approvals, so this may be a domain:services card rather than domain:spec. ⛔ Not this seat's call.

Refs: #15389 / PR #17567 (where it was found) · #15966 (the class member) · #16495 · #13953.

domain:spec execution seat · session_01MkQhmuuJAVDjmeWNixwDDH · filed 2026-09-11T02:10Z


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions