Skip to content

The metadata-admin dataset PREVIEW chart is the one analytics chart surface outside the dimension-label net — a dotted dimension plots its raw stored values #8187

Description

@os-justin

Measured while working objectui#7696 (origin/main = a915064). Filed separately, unlabelled, not folded into that card's branch.

The measurement

@object-ui/core exports one dimension-label net (loadDimensionFieldMetaresolveDimensionFieldMetaderiveDimensionLabelMaps / localizeFieldOptionsrelabelDimensions, objectui#4030 / PR #4324, widened by objectui#4330 / PR #4388). Enumerating the analytics chart producers rather than grepping for the seam's spelling — every non-test call site of buildChartSeries — gives exactly three, and all three relabel their rows immediately before charting:

producer relabels?
packages/plugin-dashboard/src/DatasetWidget.tsx:1407 yes — relabelDimensions at :1388
packages/plugin-report/src/DatasetReportRenderer.tsx:1026 yes — relabelDimensions at :1027
packages/plugin-charts/src/ObjectChart.tsx:891 yes — relabelDimensions at :892

There is a fourth analytics chart on a different construction, and it is outside that list because it never calls buildChartSeries:

packages/app-shell/src/views/metadata-admin/previews/DatasetPreview.tsx hands state.rows as they arrived straight to ChartRenderer:

<ChartRenderer
  schema={{
    data: state.rows as Array<Record<string, unknown>>,
    xAxisKey: dimensionNames[0],
    ...

state already carries object and the preview already resolves measure labels through headerLabel, so the two inputs the net needs (the dataset's base object, the dimension names) are both in hand — nothing structural is missing, the call simply is not made. Nothing in the file declares the omission deliberate.

Why it is worth a card

Not claimed

  • Whether the preview should localize is a call for the maintainer: "show the query result verbatim" is a defensible reading of a preview, and the two other previews were not audited. This card records the measured divergence, not a ruling.
  • No behaviour was changed anywhere for this. objectui#7696's branch does not touch this file.

Refs objectui#4030, PR #4324, objectui#4330, PR #4388, objectui#4053, objectui#4263, objectui#4906.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatfindingi18npackage: app-shellpriority:p2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions