Throw when color and symbol legend domains don't match - #2463
Open
RitiGrover wants to merge 1 commit into
Open
RitiGrover wants to merge 1 commit into
RitiGrover wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2384.
When
Plot.legendbuilds a symbol legend with astroke: "color"hint (i.e. bothcolorandsymbolscale options are passed), and the color scale's domain doesn't cover a value in the symbol domain, the stroke lookup silently resolves toundefinedand the symbol renders with no stroke, with no indication of why.This adds a check in
legendSymbols(src/legends/swatches.js) that validates every value in the symbol domain resolves in the color scale before rendering, and throwsthe color and symbol scale domains must matchif not, so the mismatch is caught immediately instead of producing an unstyled swatch.Test plan
vitest run test/legend-test.jsand a broader--testNamePattern legendrun; no other tests affected.eslintandprettier --checkpass on the changed files.