fix: make ChatRequest serializer None-safe for tools without parameters or function - #736
Open
betacatsling wants to merge 1 commit into
Open
betacatsling wants to merge 1 commit into
betacatsling wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #733.
ChatRequest.serialize_modelassumes every serialized tool has a non-Nonefunctioncontaining a non-Noneparametersmapping. When aToolis created withoutfunction, or aTool.Functionis created withoutparameters,model_dump()(andmodel_dump_json()) withoutexclude_none=TrueraisesPydanticSerializationError: TypeError: argument of type 'NoneType' is not iterablebecause the serializer evaluates'parameters' in None/'defs' in None.This makes the serializer tolerate missing
function/parametersso request objects can be dumped freely (e.g. for logging or debugging) regardless of how the tools were constructed. Thedefs→$defsrename behavior is unchanged whenparametersis present.Validation
tests/test_type_serialization.py:test_chat_request_serialization_tool_without_parameterstest_chat_request_serialization_tool_without_functiontest_chat_request_serialization_tool_defs_aliasPydanticSerializationError: Error calling function 'serialize_model': TypeError: argument of type 'NoneType' is not iterable.pytest tests/test_type_serialization.py— 17 passed; full suitepytest tests/— 100 passed.ruff checkandruff format --checkpass on changed files.