Skip to content

Add address space support and tests for overlap errors - #1602

Draft
bratpiorka wants to merge 4 commits into
oneapi-src:mainfrom
bratpiorka:rrudnick_tracking_overlap_fix
Draft

Add address space support and tests for overlap errors#1602
bratpiorka wants to merge 4 commits into
oneapi-src:mainfrom
bratpiorka:rrudnick_tracking_overlap_fix

Conversation

@bratpiorka

Copy link
Copy Markdown
Contributor

This pull request introduces new functionality for identifying and working with process-local address spaces in memory providers, updates the UMF versioning, and improves error handling for ambiguous memory deallocations. The changes primarily add support for querying and specifying address space identities, update provider operation interfaces, and implement the new logic in several memory providers.

Key changes include:

Address Space Identity Support

  • Introduced the umf_memory_provider_address_space_t struct to represent process-local address space identities, and added the UMF_ADDRESS_SPACE_NAMESPACE_HOST token for host address spaces.
  • Added the umfMemoryProviderGetAddressSpace API and corresponding provider operation to retrieve a provider's address space identity. Default and provider-specific implementations were added for CUDA, devdax, file, and fixed memory providers.

Provider Interface and Versioning Updates

  • Updated the provider ops structure version to 1.3 and incremented the core UMF version to 1.1 to reflect the new API and interface changes.
  • Ensured backward compatibility and proper defaulting for the new get_address_space operation in the provider ops initialization logic.

Fixed Memory Provider Enhancements

  • Added the ability to set the address space for fixed memory providers via a new parameter API (umfFixedMemoryProviderParamsSetAddressSpace) and ensured the address space is initialized and propagated correctly.

Ambiguous Free Error Handling

  • Added a new error code UMF_RESULT_ERROR_AMBIGUOUS and updated umfFree to detect and report ambiguous frees when multiple allocations match a pointer, improving safety and diagnostics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant