Fix particle source array to be correct length n_source - #545
Open
jcurtis2 wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 91.81% 91.89% +0.07%
==========================================
Files 56 56
Lines 2530 2530
Branches 144 144
==========================================
+ Hits 2323 2325 +2
+ Misses 132 131 -1
+ Partials 75 74 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The length of the particle source array was set incorrectly and the test failed to pick this up as the correct value and incorrect size were both 1. Since the test didn't trigger the problem, I added multiple sources to the test. Test asserts that particle source array length is equal the number of sources (now 2), array type is int, and that each particle source array sums to 1, which is true the absence of coagulation.