fix(llmadapters): accept a Claude session listing with no background jobs - #617
Merged
Merged
Conversation
…jobs claude agents --json lists interactive sessions too, and only background sessions carry an id, so an interactive-only listing failed discovery as an unrecognized shape. Recognize the session-listing shape and return no active jobs for it. Closes #615
monit-reviewer
approved these changes
Sep 22, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: fdc52f3a9157
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
Reviewer Coverage
go:implementation-tests— complete (broad); skipped: none; constraints: none
Inspected files (4)
internal/llmadapters/subprocess.gointernal/llmadapters/subprocess_test.gointernal/llmadapters/testdata/claude_agents_interactive_only.jsoninternal/llmadapters/testdata/claude_agents_mixed.json
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 22s | ~$1.18 (est.) | claude-sonnet-5 | cr 0.10.311
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | go:implementation-tests |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 22s wall · 1m 06s compute |
| Cost | ~$1.18 (est.) |
| Pricing basis | anthropic-public-2026-09-02 |
| Tokens | 26 in / 4.7k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5- In: 6
- Out: 2.1k
- Cache read: 120.7k
- Cache create: 110.3k
- Cost: ~$0.49 (est.)
- Duration: 21s
go:implementation-tests— claude-sonnet-5- In: 14
- Out: 2.3k
- Cache read: 492.6k
- Cache create: 112.5k
- Cost: ~$0.57 (est.)
- Duration: 35s
orchestrator-rollup— claude-sonnet-5- In: 6
- Out: 365
- Cache read: 236.3k
- Cache create: 17.7k
- Cost: ~$0.12 (est.)
- Duration: 9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude agents --jsonlists every session, and only background sessions carry anid. A listing that holds only interactive sessions is non-empty but yields no job ids, soparseClaudeBGActiveJobsfailed closed with "unrecognized non-empty JSON shape" and the reviewer's background job was lost.The parser now recognizes the session-listing shape (a non-empty array whose every element is an object with a
sessionId) and returns zero active jobs for it. Any other non-empty shape without ids still fails closed.Fixture files under
internal/llmadapters/testdata/carry an interactive-only listing and a mixed listing; the tests assert the first yields no jobs and the second yields only the background id.Type of Change
Checklist
make tidypassesmake lintpassesmake testpasses, exceptTestPiRPCReviewerExtensionLoadsInInstalledPi, which fails identically on unmodified main against the locally installed pi CLI (Unknown options: --no-builtin-tools, --no-approve)make buildpassesRelated Issues
Closes #615