Conversation
Add `cr review --without-discussion` for first-pass replays of pinned dry-run reviews. It requires --dry-run (or --no-post) and both --review-base-sha and --review-head-sha. Pinned reviews already skipped the live thread, review, and issue-comment reads, but a replay still resumed the PR's default orchestrator session and reviewer cohort sessions, which carry the earlier discussion, and it overwrote that cohort. With the flag, the run reads no discussion, resumes and updates no PR-scoped session or cohort, and so selection, reviewer, and rollup prompts see only the PR title, description, and diff. The run marker, dossier discussion artifacts, and JSON run output record without_discussion, and an incomplete run resumes only into a run with the same setting. Reviewer task fingerprints include the setting as well.
A --without-discussion replay kept its discussion out of every prompt, but a reviewer with a shell could still fetch it with gh, curl, or the GitHub API. Such replays now remove the git remotes from the workbench and each reviewer checkout, deny claude_cli reviewers WebFetch, WebSearch, and Bash commands that reach the network (gh, curl, wget, git fetch/pull/ls-remote and similar), and run codex_cli reviewers with web search and sandbox network access off. The adapters' argument validation requires these restrictions exactly when the workspace is marked offline. This narrows the tool surface rather than sandboxing the network, and the README says so. --fresh-session is now rejected with --without-discussion, since a replay never reuses or resets PR sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
cr review --without-discussionfor replaying a PR review as a first-pass review. It requires--dry-run(or--no-post) and both--review-base-shaand--review-head-sha.A pinned replay already skipped fetching review threads, issue comments, and prior reviews. The remaining leak was saved sessions: the replay resumed the PR's saved orchestrator session and each reviewer's saved session, which carry earlier live reviews including their discussion, and then saved over them. With the flag:
--jsonoutput recordwithout_discussionPR title, description, diff, and files are unchanged.
Type of Change
Checklist
make tidypassesmake lintpassesmake testpassesmake buildpassesRelated Issues
Closes #626