Skip to content

fix(release): include GoReleaser config in release paths #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzwong merged 2 commits into from
Sep 12, 2026
Merged

fix(release): include GoReleaser config in release paths #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0535dd
fix(release): include GoReleaser config in release paths
zzwong Sep 7, 2026
087cc8e
docs(release): clarify GoReleaser path trigger
zzwong Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/auto-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
auto-release:
uses: open-cli-collective/.github/.github/workflows/auto-release.yml@v1
with:
# GoReleaser configuration changes must ship even when no Go source changed.
release-paths: "**.go,go.mod,go.sum,version.txt,.goreleaser.yaml"
Comment thread
zzwong marked this conversation as resolved.
dry-run: ${{ github.event_name == 'workflow_dispatch' && (inputs.dry-run == true || inputs.dry-run == 'true') }}
secrets:
tag-token: ${{ secrets.TAP_GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ The required checks on `main` are `build`, `tidy`, `test`, `lint`, `static-relea

## Releases

There is one release stream for both binaries. `version.txt` contains the major/minor line (`1.2`), and automatic releases create `v1.2.N` tags. A squash merge to `main` whose final commit begins with `feat:` or `fix:` triggers the automatic release decision; documentation, test, CI, and chore-only merges do not cut a release.
There is one release stream for both binaries. `version.txt` contains the major/minor line (`1.2`), and automatic releases create `v1.2.N` tags. A squash merge to `main` whose final commit begins with `feat:` or `fix:` triggers the automatic release decision when it changes Go source, `go.mod`, `go.sum`, `version.txt`, or `.goreleaser.yaml`. GoReleaser configuration changes therefore ship too; documentation, test, CI, and chore-only merges do not cut a release.

@monit-reviewer monit-reviewer Sep 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prose is now accurate: the path list (**.go, go.mod, go.sum, version.txt, .goreleaser.yaml) matches release-paths in .github/workflows/auto-release.yml exactly, .goreleaser.yaml exists at the repo root with that spelling, and "GoReleaser configuration changes therefore ship too" no longer overstates coverage of packaging/**.

Remaining small issue: the list is now duplicated in prose with no pointer to where it is configured, and the next paragraph tells readers to follow the shared release/distribution standards "rather than duplicating workflow policy here." When the gate paths change, nothing links the two copies, so the guide drifts silently.

Suggested fix: name the source in the sentence, e.g. "...as configured by release-paths in .github/workflows/auto-release.yml."

Reply inline to this comment.


Each tag publishes both binaries and their platform archives through the shared release automation. Homebrew, Chocolatey, WinGet, and Linux package publication fan out from that release. Follow the [release](https://github.com/open-cli-collective/cli-common/blob/main/docs/release.md) and [distribution](https://github.com/open-cli-collective/cli-common/blob/main/docs/distribution.md) standards rather than duplicating workflow policy here.

Expand Down
Loading