Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesSubmodule version tracking
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The submodule pin updates match the stated tracking intent, with no identified production or build risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
aepfli
force-pushed
the
chore/restore-gitmodules-branch-pin
branch
2 times, most recently
from
September 14, 2026 07:37
89ba877 to
a2cb5d5
Compare
aepfli
changed the title
Renovate's git-submodules manager reads `branch` from .gitmodules as the dependency's current version. Without it there is no version to compare against, so Renovate falls back to chasing the tip of the submodule's default branch as a digest update -- which does not match the community-tooling auto-create exemption and ends up parked on the dependency dashboard. The result has been no automated updates in this repo since the pin was dropped. Restore the pin at the tag each submodule currently points at, so the next release arrives as an ordinary Renovate version PR again. Also add a header comment to .gitmodules explaining what the `branch` lines are for. The pin has now been deleted as drive-by cleanup several times across the SDK repos, in each case silently switching off updates, so it is worth saying out loud in the file itself. Note that schemas has moved from the protobuf-* tag series it used to track onto json/json-schema-*, so its pin follows the series it is actually on. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli
force-pushed
the
chore/restore-gitmodules-branch-pin
branch
2 times, most recently
from
September 15, 2026 12:14
769a138 to
a4603c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #421
Parent: open-feature/flagd-testbed#398
Restores the
branchpins that were dropped from.gitmodules.Why
Renovate's
git-submodulesmanager readsbranchfrom.gitmodulesas the dependency's current version. With the pin present it resolves against the submodule's release tags and opens an ordinary version bump, rewriting the pin itself:Without it there is no version to compare against, so Renovate chases the tip of the submodule's default branch instead — a digest update. Those don't match the
community-toolingpreset'smatchSourceUrlsauto-create exemption, so they get parked behind a dashboard checkbox rather than becoming PRs. Net effect: no automated testbed or schemas updates in this repo since the pins were removed.What this does
Restores
branch = v3.8.0onproviders/openfeature-provider-flagd/openfeature/test-harness.Restores a pin on
providers/openfeature-provider-flagd/openfeature/schemas, which lostbranch = protobuf-v0.6.1in the same PR (feat!: graceful fallback to code default when no default variant #347) and was never restored.This one is not a straight revert and is worth a look. The submodule has since moved to
1daf5ff, which is taggedjson/json-schema-v0.2.15— a different tag series from theprotobuf-*one it used to track. The pin here follows the series the submodule is actually on, so Renovate will proposejson/json-schema-*updates going forward. If trackingprotobuf-*was deliberate, say so and I'll change it.Both pins are set to the tag each submodule points at today, so this commit changes no behaviour on its own — it does not move any submodule. The next release then arrives as a normal Renovate version PR.