Conversation
The submodule already sits exactly on protobuf-v0.6.7, so it does not move: providers/openfeature-flagd-provider/schemas 3aecf63 == protobuf-v0.6.7 That is a release-please component tag and does not parse as semver, so it needs the prefix rule from open-feature/community-tooling#126 to resolve as a version. Until that lands the pin is inert, but harmless. Refs: open-feature/flagd-testbed#398, open-feature/community-tooling#125 Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the flagd-schemas submodule to the tag it already points at. Nothing moves.
Renovate reads
branchin.gitmodulesas the submodule's current version. Without it there is no version to compare against, so it can only chase the upstream default branch — see open-feature/flagd-testbed#398, and open-feature/community-tooling#126, which turns that path off entirely.providers/openfeature-flagd-provider/schemas3aecf63protobuf-v0.6.7json/json-schema-*andprotobuf-*are release-please component tags and do not parse as semver, so these pins stay inert until open-feature/community-tooling#126 merges. Harmless until then.Worth a sanity check: this repo is the only consumer on flagd-schemas'
protobuf-*series — js, java, python and rust all followjson/json-schema-*.Left unpinned:
test-harnesstracks an untagged commit two ahead ofv3.10.1, so pinning would move it rather than describe it.Refs: open-feature/community-tooling#125