reject a lone sign token as a number in decodeNumber#1703
Open
SABITHSAHEB wants to merge 1 commit into
Open
Conversation
baylesj
requested changes
Jul 14, 2026
| // below never runs and would otherwise decode it as zero. Reject it via | ||
| // decodeDouble, matching how a non-digit inside the token is handled. | ||
| if (current == token.end_) | ||
| return decodeDouble(token, decoded); |
Contributor
There was a problem hiding this comment.
Can you just return false here instead of invoking decodeDouble?
| // below never runs and would otherwise decode it as zero. Reject it via | ||
| // decodeDouble, matching how a non-digit inside the token is handled. | ||
| if (current == token.end_) | ||
| return decodeDouble(token, decoded); |
Contributor
There was a problem hiding this comment.
Same here -- if current == token.end_ and isNegative, can you just return false?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a number token that is only a sign ("-", including as an array or object element) never enters decodeNumber's digit loop, so it fell through as integer 0 instead of being rejected; route a sign-only token to decodeDouble, which rejects it, in both Reader and OurReader.