ci: add shared security scanning workflow - #2559
Open
opentelemetrybot wants to merge 4 commits into
Open
Conversation
80 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds Zizmor GitHub Actions security scanning via the OpenTelemetry shared workflow, and applies several workflow-hardening updates across existing CI/release pipelines (credential persistence, secrets scoping, and safer shell variable handling).
Changes:
- Add a new
zizmorworkflow that runs on PRs,mainpushes, and a weekly schedule, uploading SARIF to GitHub code scanning. - Harden multiple workflows by disabling persisted checkout credentials and narrowing reusable-workflow secret passing (replacing
secrets: inheritwith explicit secrets). - Reduce shell injection/word-splitting risks in workflow
run:steps by routing GitHub contexts/inputs through environment variables and quoting.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/zizmor.yml | Adds shared-workflow-based Zizmor scanning with SARIF upload permissions. |
| .github/workflows/release-layer-ruby.yml | Disables persisted checkout credentials; scopes reusable-workflow secrets; quotes ref usage for gh commands. |
| .github/workflows/release-layer-python.yml | Disables persisted checkout credentials; scopes reusable-workflow secrets; quotes ref usage for gh commands. |
| .github/workflows/release-layer-nodejs.yml | Disables persisted checkout credentials; scopes reusable-workflow secrets; reduces expression interpolation in gh commands. |
| .github/workflows/release-layer-java.yml | Disables persisted checkout credentials; scopes reusable-workflow secrets; reduces expression interpolation in gh commands. |
| .github/workflows/release-layer-collector.yml | Disables persisted checkout credentials; scopes reusable-workflow secrets; reduces expression interpolation in gh commands. |
| .github/workflows/publish-layer-collector.yml | Hardens bash input handling and output generation; disables persisted checkout credentials; scopes reusable-workflow secrets. |
| .github/workflows/pr-checks.yaml | Adds a zizmor ignore annotation for pull_request_target; disables persisted checkout credentials. |
| .github/workflows/layer-publish.yml | Declares reusable-workflow secrets; hardens bash usage by passing inputs through env and quoting. |
| .github/workflows/integration-test.yml | Declares required secret for reusable invocation; hardens bash input handling; disables persisted checkout credentials. |
| .github/workflows/fossa.yml | Disables persisted checkout credentials. |
| .github/workflows/codeql.yml | Disables persisted checkout credentials. |
| .github/workflows/ci-terraform.yml | Disables persisted checkout credentials. |
| .github/workflows/ci-shellcheck.yml | Disables persisted checkout credentials. |
| .github/workflows/ci-python.yml | Disables persisted checkout credentials. |
| .github/workflows/ci-nodejs.yml | Disables persisted checkout credentials. |
| .github/workflows/ci-java.yml | Disables persisted checkout credentials. |
| .github/workflows/ci-collector.yml | Disables persisted checkout credentials; quotes env usage in a grep invocation. |
| .github/workflows/check-links.yaml | Narrows workflow token permissions and disables persisted checkout credentials. |
| .github/dependabot.yml | Adds per-ecosystem cooldown configuration to update schedules. |
| .github/actions/build-collector-layer/action.yml | Hardens command invocation by passing action inputs through env and quoting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
opentelemetrybot
marked this pull request as ready for review
August 25, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked in open-telemetry/sig-security#293.
Adds zizmor scanning through the OpenTelemetry shared workflow.
The workflow:
regularpersona on pull requests, pushes tomain, and a repository-specific weekly schedule;After merge
zizmorcode-scanning result.If enforcement unexpectedly blocks a valid change, restore
require_zizmor = falseinopen-telemetry/adminwhile leaving scanning enabled.