Skip to content

fix: surface status --wait timeouts instead of looking successful - #774

Open
kevin9327 wants to merge 1 commit into
openai:mainfrom
kevin9327:fix/status-wait-timeout-report
Open

kevin9327 wants to merge 1 commit into
openai:mainfrom
kevin9327:fix/status-wait-timeout-report

Conversation

@kevin9327

Copy link
Copy Markdown

Problem

status --wait already records waitTimedOut on the JSON snapshot, but the default text report still looks like a normal running job and the process exits 0. /codex:status <job-id> --wait therefore cannot tell a timed-out wait from a successful status check.

Change

  • Print Timed out after Ns while the job was still running. in the text report.
  • Exit 1 when a wait times out.
  • Keep waitTimedOut and timeoutMs on the JSON snapshot.

Test

status --wait reports a timeout in text output when the job is still active fails on main (no timeout line, exit 0) and passes after this change.

AI-assisted (Grok)

status --wait already set waitTimedOut on the JSON snapshot, but text
output still rendered a normal running job and the process exited 0.
Callers that poll with /codex:status <id> --wait therefore treated a
timed-out wait as a finished status check. Print the timeout and exit
non-zero while keeping waitTimedOut in the JSON payload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant