Skip to content

feat(typescript): attribute Codex Security workloads - #644

Merged
kmbroai merged 6 commits into
mainfrom
dev/kyleb/thread-source-attribution
Aug 25, 2026
Merged

feat(typescript): attribute Codex Security workloads#644
kmbroai merged 6 commits into
mainfrom
dev/kyleb/thread-source-attribution

Conversation

@kmbroai

@kmbroai kmbroai commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Attribute Codex Security requests by workload so scan, validation, remediation, and comparison traffic can be distinguished independently from the SDK or CLI surface that initiated it.

Changes

  • Set security_scan on primary scans, automatic component planning, scan-owned validation turns, and bundled Deep Scan workers.
  • Set security_validation on standalone SDK and CLI validation requests.
  • Set security_remediation on patch requests.
  • Set security_scan_comparison on finding-comparison requests.
  • Forward attribution through SDK thread creation, CLI exec, and app-server thread creation.
  • Centralize Codex Security thread-source values and their derived internal types while preserving the existing wire labels.
  • Upgrade the pinned Codex CLI and SDK, including the bundled runtime, to 0.149.1.
  • Preserve main's bundled plugin version 0.1.59 while updating its Deep Scan worker runtime attribution.
  • Document the minimum supported custom Codex executable and add regression coverage.

Testing

  • Focused attribution and integration tests: 240 passed, 5 platform-specific skipped, 0 failed.
  • Bundled-plugin upgrade and nested-worker smoke tests: 2 passed, 0 failed.
  • TypeScript typecheck passed.
  • Build and npm package creation passed.
  • Installed-package contract and smoke validation passed, including 113 bundled plugin files, the bundled Codex version, and nested-worker startup.
  • git diff --check passed.

Risk and rollout

The attribution values apply when creating new threads; resumed threads retain their existing source. SDK-versus-CLI attribution remains in the existing surface metadata.

Custom Codex executables must support thread source attribution for both exec and app-server requests. The bundled and pinned Codex version is upgraded to 0.149.1 to provide that support. The bundled security plugin remains at main's 0.1.59 revision and preserves main's refresh behavior.

No new Codex Security command, argument, flag, environment variable, or accepted value is introduced. Rollout follows the normal package release process.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the enhancement New feature or request label Aug 25, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-08-25T07:09:58.323388Z 2a748ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

mldangelo-oai
mldangelo-oai previously approved these changes Aug 25, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kmbroai
kmbroai merged commit 88f2d02 into main Aug 25, 2026
36 checks passed
@kmbroai
kmbroai deleted the dev/kyleb/thread-source-attribution branch August 25, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants