keycloak theme fixes#238
Open
Cassolette wants to merge 3 commits into
Open
Conversation
Support passkey sign in button via kcButtonSecondaryClass [1], since the deprecated keycloak theme which opencloud imports, does not support it. [1]: https://github.com/keycloak/keycloak/blob/main/themes/src/main/resources/theme/base/login/passkeys.ftl
Member
|
Can we work on that? |
Member
|
@micbar sure! We should switch to the new theming. Let's add it to the next sprint ? |
Member
|
👍 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR addresses two parts.
keycloak.v2login theme.Reference: keycloak.v2 theme
This is because the keycloak theme which opencloud used as a base has been deprecated and no longer receives support. We fix this by defining the classes and styles required by the passkeys button.
Note: it's a bandaid fix for as long as we depend on the old theme which could be removed in the future.