test: upgrade output-comparison tooling to odr_core_test 2.0.0#587
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1443c3753
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Bump the CI public/private output comparisons' `--max-workers` from 1 to 2. Update `compare_output_server.sh` to the 2.0.0 image and reorder its flags, and add `compare_output_cli.sh` for running the CLI comparison locally against `cmake-build-relwithdebinfo` output. The CLI entry point is `compare-html` in both htmlcmp 1.2.4 (installed in CI) and 2.0.0 (the module it now points at is `compare_output_cli`, but the console script stays `compare-html`); there is no `compare-html-cli` executable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andiwand
force-pushed
the
tooling-compare-html-cli
branch
from
b1443c3 to
6356273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Upgrades the HTML output-comparison tooling:
compare-html-cli(wascompare-html) and--max-workers 2(was 1).compare_output_server.shbumped to theodr_core_test:2.0.0image, with flags reordered.compare_output_cli.shfor running the CLI comparison locally againstcmake-build-relwithdebinfooutput.