Skip to content

fix: run PSR via uv again now that 10.6.2 fixes the GitPython break - #439

Closed
irfanuddinahmad wants to merge 2 commits into
openedx:masterfrom
irfanuddinahmad:irfanuddinahmad/restore-uv-psr-invocation
Closed

fix: run PSR via uv again now that 10.6.2 fixes the GitPython break#439
irfanuddinahmad wants to merge 2 commits into
openedx:masterfrom
irfanuddinahmad:irfanuddinahmad/restore-uv-psr-invocation

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Now that upstream ships a fix for the GitPython break (python-semantic-release#1476, released in PSR 10.6.2), run python-semantic-release itself through uv rather than the official Docker-based action -- consistent with the rest of this repo's uv migration, and avoids that action's Docker image, which only bundles pip, not uv.

build_command stays on uv build accordingly, so there's no pip anywhere in the release path.

Verified locally:

  • uvx --from "python-semantic-release==10.6.2" semantic-release --noop -v version --no-changelog --no-vcs-release resolves cleanly
  • SETUPTOOLS_SCM_PRETEND_VERSION=... uv build produces correct dist/ artifacts

Test plan

  • CI green on this PR
  • Next merge to master (this commit itself, fix: type) cuts a real release and exercises the uv-based release path end-to-end

openedx#438 reverted all the way back to the official Docker-based action once
upstream fixed python-semantic-release/python-semantic-release#1476, but
that wasn't necessary -- it also undid the uv-based invocation and
build_command from openedx#435/openedx#436 for no reason tied to the actual bug.

The gitpython pin was only ever needed to work around the bug; with PSR
10.6.2 (which no longer references the removed GitPython attribute) that
constraint isn't needed at all, uvx resolves and runs it cleanly. Verified
both halves locally: `uvx --from "python-semantic-release==10.6.2" ...`
runs without error, and `SETUPTOOLS_SCM_PRETEND_VERSION=... uv build`
produces correct dist/ artifacts.

Keeping the uv-based invocation avoids reintroducing pip anywhere in this
workflow (the official action's Docker image only has pip, not uv),
consistent with this org's uv-native CI standard.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 31, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/committers-events.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@irfanuddinahmad
irfanuddinahmad requested review from bmtcril and removed request for bmtcril September 1, 2026 13:33
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants