prevent translation keys from appearing in the Streaming Now panel - #4870
Merged
Conversation
|
|
Contributor
WalkthroughThe language selector now refreshes the ChangesTranslation refresh
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
evanpelle
approved these changes
Aug 6, 2026
evanpelle
pushed a commit
that referenced
this pull request
Aug 6, 2026
…4870) ## Description: This PR addresses an issue reported in the translation server where the Streaming Now panel temporarily displayed translation keys when using a language other than English. The `streaming-now` component was not refreshed after translations finished loading, so the correct strings did not appear until the next stream refresh. before <img width="323" height="152" alt="スクリーンショット 2026-08-05 6 58 23" src="https://github.com/user-attachments/assets/d69ec43b-fab6-44e5-bb7e-cd58ff94d735" /> ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: aotumuri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses an issue reported in the translation server where the Streaming Now panel temporarily displayed translation keys when using a language other than English.
The
streaming-nowcomponent was not refreshed after translations finished loading, so the correct strings did not appear until the next stream refresh.before

Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
aotumuri