Document C compiler requirement for map generator 📝 - #4877
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe map generator README now requires a C compiler for the WebP dependency. It provides setup instructions for Windows, macOS, and Linux. ChangesMap generator installation
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/README.md`:
- Line 15: Update the Windows installation guidance in the README to name the
exact MSYS2 UCRT64 package and installation command,
`mingw-w64-ucrt-x86_64-gcc`, and clarify that `gcc` must be used from the
corresponding MSYS2 terminal or compiler directory; keep the alternative TDM-GCC
guidance unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0021e0c1-ad33-462a-b589-6b643a9fabd4
📒 Files selected for processing (1)
map-generator/README.md
|
@FloPinguin this seems no longer needed now that #4879 has been merged, correct? |
Correct :) |
Description:
Add a C compiler installation step to the map-generator README. The
chai2010/webpdependency bundles libwebp-1.4 and uses CGO, so a C compiler (GCC on Windows/Linux, Xcode CLI tools on macOS) is required to build the map generator.Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
FloPinguin