feat(web): expose bounded terminal details - #389
Conversation
|
CI context: both Linux Node jobs reach the pre-existing packed standalone Web CLI smoke, install the tarball, and then the server exits before announcing its origin ( This PR does not change package metadata, CLI startup, or peer-dependency resolution. Its local check, focused tests, full Node suite, and Vitest suite pass as recorded in the PR body. |
tt-a1i
left a comment
There was a problem hiding this comment.
Exact-head standards/spec review found no confirmed P2 or higher issue. This usefully extends the SessionManager-owned observer seam with exact-id terminal details, bounded UTF-8 output, explicit missing/unavailable receipts, and no private spill-path disclosure or lifecycle mutations. Focused registry/host tests passed 34/34 and current PR CI is green. Recommend retaining this backend capability. It currently conflicts with main in host code/tests, so approval covers the reviewed contribution; resolve those conflicts and validate the integrated tree before merging. There is no terminal-detail browser panel delivered by this slice. No source edits or merge performed.
…444) Integrate Session-scoped terminal details from #389, Pi thinking reads from #375, and unarchive from #361 while preserving current trust diagnostics. Add authenticated endpoint and persistent unarchive integration tests. Co-authored-by: testikun <320479488+testikun@users.noreply.github.com> Co-authored-by: seekskyworld <djh1813553759@gmail.com>
|
Integrated into main through #444 (1919542). The Session-scoped terminal detail implementation and its tests were retained, with neutral host conflict resolution. Original contributor testikun is credited as a co-author. Full local validation and Node 22/24/26, Web E2E and Windows CI passed. Closing this source PR as integrated; thank you for the contribution. |
Problem
The compact capability snapshot tracked by #346 is suitable for status badges but cannot provide exact Background Terminal evidence. The browser needs a Session-scoped detail read without reconstructing lifecycle state or learning private spill paths.
Value
Operators can inspect authoritative command, status, timing, and bounded output evidence for one terminal while retaining explicit truncation and recovery signals.
Approach
This is distinct from #366, which exposes only the compact capability collection. Lifecycle controls and UI panels remain separate follow-ups.
Validation
Impact
Related to #346.