bugfix: change return values to NGX_DECLINED in precontent_by_lua#2510
Merged
zhuizhuhaomeng merged 1 commit intoJun 20, 2026
Merged
Conversation
HanadaLee
force-pushed
the
fixed_precontent_by_lua_no_postpone
branch
2 times, most recently
from
c0b3de3 to
a5b695f
Compare
NGX_HTTP_PRECONTENT_PHASE uses ngx_http_core_generic_phase. Previous implementations were ported from access_by_lua*, and the handler would return NGX_OK at the end. If "preaccess_by_lua_no_postpone on;" is configured, subsequent handlers in the same phase would be skipped. Therefore, it should return NGX_DECLINED instead.
HanadaLee
force-pushed
the
fixed_precontent_by_lua_no_postpone
branch
from
a5b695f to
b808a29
Compare
zhuizhuhaomeng
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NGX_HTTP_PRECONTENT_PHASE uses ngx_http_core_generic_phase. Previous implementations were ported from access_by_lua*, and the handler would return NGX_OK at the end. If "preaccess_by_lua_no_postpone on;" is configured, subsequent handlers in the same phase would be skipped. Therefore, it should return NGX_DECLINED instead.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.