[release-5.0] OCPBUGS-114740: E2E: Minor fixes to Memory Manager and hugepages split tests - #1622
Conversation
…tests The restricted and single-numa-node fixtures assumed that configuring 20 x 2Mi hugepages without a NUMA Node would split evenly across both NUMA nodes (10/10). That is not how cmdline hugepages=N works: the kernel places pages system-wide, and Memory Manager can see an uneven split (for example 24Mi on NUMA 0 and 16Mi on NUMA 1). With 24Mi free on one node, a Guaranteed pod requesting 24Mi hugepages + 2 CPUs was admitted instead of failing with TopologyAffinityError. Pin 10 x 2Mi hugepages on each NUMA node so each zone has only 20Mi, restoring the rejection expectation. Also DeferCleanup test pods so flake retries do not leak hugepages from a failed attempt. AI Attribution: AIA Human-AI blend, New content, Human-initiated, Reviewed, Cursor 3.0.16 v1.0 Signed-off-by: Niranjan M.R <mniranja@redhat.com>
Hardcoding isolated=1-2 and reserved=0,3 on large-CPU nodes inflated tuned.non_isolcpus and systemd.cpu_affinity, which could drop later cmdline args such as hugepages and break test_id:34081. Keep the profile's CPU set and assert isolcpus, affinity, and ReservedSystemCPUs against those values instead. - Add FindCmdlineParam helper to nodes package for parsing /proc/cmdline parameters by splitting on whitespace instead of using regex - Compare isolcpus using exact argument match instead of ContainSubstring - Compare systemd.cpu_affinity against non-isolated CPUs (online \ isolated) instead of reserved, matching tuned's not_isolated_cores_expanded - Validate tuned.non_isolcpus mask value against expected non-isolated CPU mask instead of only checking presence - Simplify ReservedSystemCPUs to compare directly against reserved CPUs Signed-off-by: Niranjan M.R <mniranja@redhat.com> AI Attribution: AIA Human-AI blend, New content, Human-initiated, Reviewed, Cursor 3.0.16 v1.0
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-113647 has been cloned as Jira Issue OCPBUGS-114740. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-114740, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @mrniranjan |
openshift-ci-robot
added
the
verified
|
@mrniranjan: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
This is an automated cherry-pick of #1578
/assign mrniranjan