OLS-3859: Enable read-only Tekton tools

[waveywaves]

Description

Enable the Tekton toolset in the operator-managed OpenShift MCP server while enforcing a read-only, non-destructive configuration. Target compatibility filtering hides Tekton tools when the cluster does not serve tekton.dev/v1 PipelineRuns.

The downstream MCP image can sync additional Tekton tools, including PipelineRun diagnosis, independently after their upstream changes merge.

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up dependent library

Related Tickets & Documents

• Related Issue # OLS-3859
• Closes #

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• make test
• Verified the generated MCP TOML pins the Tekton toolset and sets read_only, disable_destructive, and target compatibility filtering to true.

Summary by CodeRabbit

• New Features

  • Added support for Tekton tools.
  • Enabled target-compatible tool filtering.

• Security

  • Configured the MCP server for read-only operation.
  • Disabled destructive operations to help prevent unintended changes.

[openshift-ci-robot]

@waveywaves: This pull request references OLS-3859 which is a valid jira issue.

Details

In response to this:

Description

Enable the Tekton toolset in the operator-managed OpenShift MCP server while enforcing a read-only, non-destructive configuration. Target compatibility filtering hides Tekton tools when the cluster does not serve tekton.dev/v1 PipelineRuns.

The downstream MCP image can sync additional Tekton tools, including PipelineRun diagnosis, independently after their upstream changes merge.

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up dependent library

Related Tickets & Documents

• Related Issue # OLS-3859
• Closes #

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• make test
• Verified the generated MCP TOML pins the Tekton toolset and sets read_only, disable_destructive, and target compatibility filtering to true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5886fd51-ba3c-4a63-8151-9fc28267df07

📥 Commits

Reviewing files that changed from the base of the PR and between 1a110ef and e5ab431.

📒 Files selected for processing (2)

• internal/controller/ocpmcp/assets.go
• internal/controller/ocpmcp/assets_test.go

---

📝 Walkthrough

Walkthrough

The MCP server TOML now uses read-only, non-destructive settings, target compatibility filters, and the Tekton toolset. The ConfigMap generation test validates these settings.

Changes

MCP configuration

Layer / File(s)	Summary
MCP safety and toolset configuration internal/controller/ocpmcp/assets.go, internal/controller/ocpmcp/assets_test.go	The generated TOML enables read-only mode, disables destructive operations, enables target compatibility filters, and adds the tekton toolset. Tests validate the updated configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/lightspeed-operator#1660: Both PRs update the MCP TOML configuration and its generation test, including opposing read_only settings.

Suggested reviewers: blublinsky

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: enabling read-only Tekton tools in the operator-managed OpenShift MCP server.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hi @waveywaves. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.