OU-1220: Add column to display dashboard id in perses dashboard list page

[zhuje]

JIRA

• https://redhat.atlassian.net/browse/OU-1220

Image

• quay.io/jezhu/monitoring-plugin:u1220-perses-dashboard-id-sep10-2

Screenshot

Summary by CodeRabbit

• New Features
  • Dashboard lists now show each dashboard’s immutable identifier in a separate sortable Name column.
  • Added explanatory tooltip text for the dashboard identifier.
  • The previous dashboard name column is now labeled Display Name for clearer distinction.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@zhuje: This pull request references OU-1220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

JIRA

• https://redhat.atlassian.net/browse/OU-1220

Image

• quay.io/jezhu/monitoring-plugin:u1220-perses-dashboard-id-sep10-2

Screenshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 271f4a79-f4a7-4aa0-8ae4-65c3efcb7cef

📥 Commits

Reviewing files that changed from the base of the PR and between 0ef33e6 and eddd784.

📒 Files selected for processing (1)

• web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The dashboard list now separates immutable dashboard identifiers from display names. It adds identifier sorting, tooltip and accessibility text, fallback handling, and a dedicated table cell.

Changes

Dashboard list identity

Layer / File(s)	Summary
Dashboard identity table flow web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx	DashboardRow stores the immutable dashboard identifier. Row construction derives the identifier and uses it when no display name exists. The table adds a sortable “Name” column and relabels the existing column to “Display Name.”

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: peteryurkovich

Merge Risk: ⚪ Minimal · up to eddd7

The dashboard list now displays immutable identifiers separately from display names with sorting and accessible explanatory text. No actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding a dashboard ID column to the Perses dashboard list page. It is specific, concise, and related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only DashboardList.tsx. The authoritative diff adds dashboard table data, sorting, and UI labels, but no It(), Describe(), Context(), When(), or other test title. No…
Test Structure And Quality	✅ Passed	PASS: The reviewed range changes only DashboardList.tsx, a TypeScript React component. The patch contains no Ginkgo test code or test constructs such as It, BeforeEach, AfterEach, Eventually…
Microshift Test Compatibility	✅ Passed	The pull request changes only DashboardList.tsx, a React/TypeScript dashboard table. The authoritative diff adds a dashboard ID field, sorting, tooltip text, and table rendering. It adds no Ginkgo t…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only DashboardList.tsx, a TSX UI component. The diff adds dashboard ID display and sorting logic. It adds no Ginkgo e2e tests and contains no It(), Describe(), `Context(…
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx. The diff adds a dashboard ID table field, sorting, tooltip text, and rendering logic. It…
Ote Binary Stdout Contract	✅ Passed	PASS — The authoritative pull-request diff changes only web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx. The changes add a dashboard table column and sorting logic in …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only DashboardList.tsx, a TypeScript dashboard table component. The diff adds a dashboard ID field, sorting, tooltip text, and a table cell. It adds no Ginkgo tests and no I…
No-Weak-Crypto	✅ Passed	The pull request changes only DashboardList.tsx. The additions create and sort a dashboard ID, add table labels and tooltip text, and render the ID column. The changed file has no MD5, SHA1, DES, 3D…
Container-Privileges	✅ Passed	The pull request changes only DashboardList.tsx. The patch adds dashboard table data, sorting, labels, and tooltip text. It does not modify a container or Kubernetes manifest and contains none of th…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request only adds the dashboard identifier to table rows, sorting, and rendering. The changed file adds no logging, telemetry, audit, or console calls. The identifier is displayed in th…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• web/src/features/perses-dashboards/OWNERS [zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@zhuje: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	eddd784	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[PeterYurkovich]

Like 90% of the time this field is going to be very close or the same as the actual name. Could we add something like the console has on other pages where the user can select the visible columns, that way this can be hidden by default? I also believe the bug in the console has been fixed that made us use our own data table so we can swap to using theirs now if you don't want to add the implementation on top of our custom one.

If you want I can do that fix first so this PR can just use the console SDK datatable to add the hidden columns thing, just lmk